Fix AttributeError ('str' object has no attribute 'room_id') in react_to_event #2

New Issue

ben · 2024-12-31T13:40:35Z

ben commented

2024-12-31 13:40:35 +00:00

When _cb_decryption_fail calls react_to_event:

  File "/home/ben/projects/notflixbot/notflixbot/matrix.py", line 298, in _cb_decryption_fail
    await self.react_to_event(room.room_id, event.event_id,
          │    │              │    │        │     └ '$aCKYmfuVLVXFd49OmW40BSQX9nuD4NsqowzsMzbbk_g'
          │    │              │    │        └ MegolmEvent(source={'content': {'algorithm': 'm.megolm.v1.
aes-sha2', 'ciphertext': 'AwgCEqAMBSDjLr0uLMkpz0ZMv0pRsN0IX/lt8E4jk...
          │    │              │    └ '!CRwztTiHGQvFqgSjnc:sudo.is'
          │    │              └ <nio.rooms.MatrixRoom object at 0x7f64b1867e20>
          │    └ <function MatrixClient.react_to_event at 0x7f64b1cda940>
          └ <notflixbot.matrix.MatrixClient object at 0x7f64b19af790>

  File "/home/ben/projects/notflixbot/notflixbot/matrix.py", line 498, in react_to_event
    room.room_id,
    └ '!CRwztTiHGQvFqgSjnc:sudo.is'

AttributeError: 'str' object has no attribute 'room_id'

The react_to_event method expects the room parameter to be an object, but _cb_decryption_fail passes a string instead.

When `_cb_decryption_fail` calls `react_to_event`: ```python3 File "/home/ben/projects/notflixbot/notflixbot/matrix.py", line 298, in _cb_decryption_fail await self.react_to_event(room.room_id, event.event_id, │ │ │ │ │ └ '$aCKYmfuVLVXFd49OmW40BSQX9nuD4NsqowzsMzbbk_g' │ │ │ │ └ MegolmEvent(source={'content': {'algorithm': 'm.megolm.v1. aes-sha2', 'ciphertext': 'AwgCEqAMBSDjLr0uLMkpz0ZMv0pRsN0IX/lt8E4jk... │ │ │ └ '!CRwztTiHGQvFqgSjnc:sudo.is' │ │ └ <nio.rooms.MatrixRoom object at 0x7f64b1867e20> │ └ <function MatrixClient.react_to_event at 0x7f64b1cda940> └ <notflixbot.matrix.MatrixClient object at 0x7f64b19af790> File "/home/ben/projects/notflixbot/notflixbot/matrix.py", line 498, in react_to_event room.room_id, └ '!CRwztTiHGQvFqgSjnc:sudo.is' AttributeError: 'str' object has no attribute 'room_id' ``` The `react_to_event` method expects the `room` parameter to be an object, but `_cb_decryption_fail` passes a string instead.

ben referenced this issue from a commit

2024-12-31 13:41:56 +00:00

Pass the object instead of the string attribute, fixes #2

ben closed this issue

2024-12-31 13:41:56 +00:00

ben commented

2024-12-31 13:46:42 +00:00

This was also opened as ops/meta#1, fixed half of it.

ben referenced this issue

2024-12-31 13:47:59 +00:00

On exit: `NoneType` can't be used in `'await'` expression #3

Sign in to join this conversation.