buildroot/package/ccache/ccache.mk

78 lines
2.7 KiB
Makefile
Raw Normal View History

################################################################################
#
# ccache
#
################################################################################
CCACHE_VERSION = 4.9.1
CCACHE_SITE = https://github.com/ccache/ccache/releases/download/v$(CCACHE_VERSION)
.mk files: bulk aligment and whitespace cleanup of assignments The Buildroot coding style defines one space around make assignments and does not align the assignment symbols. This patch does a bulk fix of offending packages. The package infrastructures (or more in general assignments to calculated variable names, like $(2)_FOO) are not touched. Alignment of line continuation characters (\) is kept as-is. The sed command used to do this replacement is: find * -name "*.mk" | xargs sed -i \ -e 's#^\([A-Z0-9a-z_]\+\)\s*\([?:+]\?=\)\s*$#\1 \2#' -e 's#^\([A-Z0-9a-z_]\+\)\s*\([?:+]\?=\)\s*\([^\\]\+\)$#\1 \2 \3#' -e 's#^\([A-Z0-9a-z_]\+\)\s*\([?:+]\?=\)\s*\([^\\ \t]\+\s*\\\)\s*$#\1 \2 \3#' -e 's#^\([A-Z0-9a-z_]\+\)\s*\([?:+]\?=\)\(\s*\\\)#\1 \2\3#' Brief explanation of this command: ^\([A-Z0-9a-z_]\+\) a regular variable at the beginning of the line \([?:+]\?=\) any assignment character =, :=, ?=, += \([^\\]\+\) any string not containing a line continuation \([^\\ \t]\+\s*\\\) string, optional whitespace, followed by a line continuation character \(\s*\\\) optional whitespace, followed by a line continuation character Hence, the first subexpression handles empty assignments, the second handles regular assignments, the third handles regular assignments with line continuation, and the fourth empty assignments with line continuation. This expression was tested on following test text: (initial tab not included) FOO = spaces before FOO = spaces before and after FOO = tab before FOO = tab and spaces before FOO = tab after FOO = tab and spaces after FOO = spaces and tab after FOO = \ FOO = bar \ FOO = bar space \ FOO = \ GENIMAGE_DEPENDENCIES = host-pkgconf libconfuse FOO += spaces before FOO ?= spaces before and after FOO := FOO = FOO = FOO = FOO = $(MAKE1) CROSS_COMPILE=$(TARGET_CROSS) -C AT91BOOTSTRAP3_DEFCONFIG = \ AXEL_DISABLE_I18N=--i18n=0 After this bulk change, following manual fixups were done: - fix line continuation alignment in cegui06 and spice (the sed expression leaves the number of whitespace between the value and line continuation character intact, but the whitespace before that could have changed, causing misalignment. - qt5base was reverted, as this package uses extensive alignment which actually makes the code more readable. Finally, the end result was manually reviewed. Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com> Cc: Yann E. Morin <yann.morin.1998@free.fr> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2014-10-07 07:06:03 +00:00
CCACHE_SOURCE = ccache-$(CCACHE_VERSION).tar.xz
CCACHE_LICENSE = GPL-3.0+, others
CCACHE_LICENSE_FILES = LICENSE.adoc GPL-3.0.txt
HOST_CCACHE_DEPENDENCIES = host-hiredis host-zstd
# We are ccache, so we can't use ccache
HOST_CCACHE_CONF_OPTS += \
-UCMAKE_C_COMPILER_LAUNCHER \
-UCMAKE_CXX_COMPILER_LAUNCHER \
package/ccache: always disable developer mode Ccache CMake build system has some conditions that automatically enables a developer mode (sets CCACHE_DEV_MODE=ON). See [1]. More specifically, if CCACHE_DEV_MODE is unset AND the environment variable "CI" is set, CCACHE_DEV_MODE is set to "ON". This situation can happen when Buildroot builds are executed in Jenkins jobs, for example. Since Buildroot does not set CCACHE_DEV_MODE and Jenkins sets the "CI" environment variable, this ccache developer mode can be enabled in an unexpected way for the Buildroot user. For example, it happened that a Jenkins build breaks, while the build with the same configuration in the user session is working. One of the effects of enabling this ccache developer mode, is to treat compiler warnings as errors, see [3]. This can lead to build error, depending on the ccache version and the host compiler being used. This behavior can be reproduced and observed, with commands: cat > .config <<EOF BR2_aarch64=y BR2_TOOLCHAIN_EXTERNAL=y BR2_CCACHE=y BR2_PACKAGE_BUSYBOX=y EOF make olddefconfig make clean make host-ccache Outputs: ... -- Ccache version: 4.9.1 -- Ccache dev mode: OFF -- Setting CMAKE_BUILD_TYPE to Release as none was specified. ... Whereas: make clean CI=true make host-ccache Outputs: ... -- Ccache version: 4.9.1 -- Ccache dev mode: ON -- Setting CMAKE_BUILD_TYPE to Debug as none was specified. ... For a failure example: on Fedora 40 with host gcc 14.1.1, Buildroot at tag 2024.02 has ccache 4.8.2. Host ccache can fail, when building with "CI=true make host-ccache" with output: /buildroot/output/build/host-ccache-4.8.2/src/third_party/fmt/core.h:3119:44: in 'constexpr' expansion of 'fmt::v8::make_format_args<>(args#0, args#1)' /buildroot/output/build/host-ccache-4.8.2/src/third_party/fmt/core.h:1706:15: error: possibly dangling reference to a temporary [-Werror=dangling-reference] 1706 | const auto& arg = arg_mapper<Context>().map(std::forward<T>(val)); | ^~~ This commit sets CCACHE_DEV_MODE=OFF to make the ccache behavior more deterministic in Buildroot, independently of being used in a CI tool or not. [1] https://github.com/ccache/ccache/blob/v4.9.1/CMakeLists.txt#L56 [2] https://github.com/jenkinsci/jenkins/blob/jenkins-2.459/core/src/main/java/jenkins/model/CoreEnvironmentContributor.java#L43 [3] https://github.com/ccache/ccache/blob/v4.9.1/cmake/StandardWarnings.cmake#L5 Reported-by: Xavier Roumegue <xroumegue@gmail.com> Signed-off-by: Julien Olivain <ju.o@free.fr> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
2024-05-28 19:20:08 +00:00
-DCCACHE_DEV_MODE=OFF \
-DZSTD_FROM_INTERNET=OFF \
-DHIREDIS_FROM_INTERNET=OFF \
-DENABLE_TESTING=OFF
# Patch host-ccache as follows:
# - Use BR_CACHE_DIR instead of CCACHE_DIR, because CCACHE_DIR
# is already used by autotargets for the ccache package.
# BR_CACHE_DIR is exported by Makefile based on config option
# BR2_CCACHE_DIR.
# - Change hard-coded last-ditch default to match path in .config, to avoid
# the need to specify BR_CACHE_DIR when invoking ccache directly.
# CCache replaces "home_dir" with the home directory of the current user,
# so rewrite BR_CACHE_DIR to take that into consideration for SDK purpose
HOST_CCACHE_DEFAULT_CCACHE_DIR = $(patsubst $(HOME)/%,%,$(BR_CACHE_DIR))
define HOST_CCACHE_PATCH_CONFIGURATION
sed -i 's,getenv("CCACHE_DIR"),getenv("BR_CACHE_DIR"),' $(@D)/src/Config.cpp
sed -i 's,".ccache","$(HOST_CCACHE_DEFAULT_CCACHE_DIR)",' $(@D)/src/Config.cpp
sed -i 's,"/.cache/ccache","/$(HOST_CCACHE_DEFAULT_CCACHE_DIR)",' $(@D)/src/Config.cpp
sed -i 's,"/.config/ccache","/$(HOST_CCACHE_DEFAULT_CCACHE_DIR)",' $(@D)/src/Config.cpp
sed -i 's,getenv("XDG_CACHE_HOME"),nullptr,' $(@D)/src/Config.cpp
sed -i 's,getenv("XDG_CONFIG_HOME"),nullptr,' $(@D)/src/Config.cpp
endef
HOST_CCACHE_POST_PATCH_HOOKS += HOST_CCACHE_PATCH_CONFIGURATION
define HOST_CCACHE_MAKE_CACHE_DIR
mkdir -p $(BR_CACHE_DIR)
endef
HOST_CCACHE_POST_INSTALL_HOOKS += HOST_CCACHE_MAKE_CACHE_DIR
# Provide capability to do initial ccache setup (e.g. increase default size)
BR_CCACHE_INITIAL_SETUP = $(call qstrip,$(BR2_CCACHE_INITIAL_SETUP))
ifneq ($(BR_CCACHE_INITIAL_SETUP),)
define HOST_CCACHE_DO_INITIAL_SETUP
@$(call MESSAGE,"Applying initial settings")
$(CCACHE) $(BR_CCACHE_INITIAL_SETUP)
$(CCACHE) -s
endef
HOST_CCACHE_POST_INSTALL_HOOKS += HOST_CCACHE_DO_INITIAL_SETUP
endif
$(eval $(host-cmake-package))
ifeq ($(BR2_CCACHE),y)
ccache-stats: host-ccache
$(Q)$(CCACHE) -s
ccache-options: host-ccache
ifeq ($(CCACHE_OPTIONS),)
$(Q)echo "Usage: make ccache-options CCACHE_OPTIONS=\"opts\""
$(Q)echo "where 'opts' corresponds to one or more valid ccache options" \
"(see ccache help text below)"
$(Q)echo
endif
$(Q)$(CCACHE) $(CCACHE_OPTIONS)
endif