53 lines
2.7 KiB
Diff
53 lines
2.7 KiB
Diff
From b674a15d5c0133e76f3b1c4372ff4cf50d6cb608 Mon Sep 17 00:00:00 2001
|
|
From: Somdev Sangwan <s0md3v@gmail.com>
|
|
Date: Fri, 2 Jun 2023 23:49:53 +0530
|
|
Subject: [PATCH] prevent object destruction compile error (#16134)
|
|
|
|
### Description
|
|
The proposed fix is to store the result of AsBlockSparse() in a variable
|
|
to ensure the object isn't destroyed until the end of the current scope.
|
|
|
|
### Motivation and Context
|
|
"own_buffer_tensor" is a temporary object that is destroyed at the end
|
|
of the expression and causes a compile error.
|
|
---
|
|
onnxruntime/test/framework/sparse_kernels_test.cc | 9 ++++++---
|
|
1 file changed, 6 insertions(+), 3 deletions(-)
|
|
|
|
diff --git a/onnxruntime/test/framework/sparse_kernels_test.cc b/onnxruntime/test/framework/sparse_kernels_test.cc
|
|
index 1a535144f4..b269b3231b 100644
|
|
--- a/onnxruntime/test/framework/sparse_kernels_test.cc
|
|
+++ b/onnxruntime/test/framework/sparse_kernels_test.cc
|
|
@@ -1815,7 +1815,8 @@ TEST(SparseTensorConversionTests, BlockSparse) {
|
|
ASSERT_EQ(data_blocks.size(), data_span.size());
|
|
ASSERT_TRUE(std::equal(data_blocks.cbegin(), data_blocks.cend(), data_span.begin(), data_span.end()));
|
|
|
|
- const auto& indices = own_buffer_tensor.AsBlockSparse().Indices();
|
|
+ auto block_sparse = own_buffer_tensor.AsBlockSparse();
|
|
+ const auto& indices = block_sparse.Indices();
|
|
ASSERT_EQ(indices_shape, indices.Shape());
|
|
auto indices_span = indices.DataAsSpan<int32_t>();
|
|
ASSERT_TRUE(std::equal(blocksparse_indices.cbegin(), blocksparse_indices.cend(),
|
|
@@ -1834,7 +1835,8 @@ TEST(SparseTensorConversionTests, BlockSparse) {
|
|
ASSERT_EQ(data_blocks.size(), data_span.size());
|
|
ASSERT_TRUE(std::equal(data_blocks.cbegin(), data_blocks.cend(), data_span.begin(), data_span.end()));
|
|
|
|
- const auto& indices = user_buffer_tensor.AsBlockSparse().Indices();
|
|
+ auto block_sparse = user_buffer_tensor.AsBlockSparse();
|
|
+ const auto& indices = block_sparse.Indices();
|
|
ASSERT_EQ(indices_shape, indices.Shape());
|
|
auto indices_span = indices.DataAsSpan<int32_t>();
|
|
ASSERT_TRUE(std::equal(blocksparse_indices.cbegin(), blocksparse_indices.cend(),
|
|
@@ -1855,7 +1857,8 @@ TEST(SparseTensorConversionTests, BlockSparse) {
|
|
ASSERT_EQ(expected_span.size(), data_span.size());
|
|
ASSERT_TRUE(std::equal(expected_span.begin(), expected_span.end(), data_span.begin(), data_span.end()));
|
|
|
|
- const auto& indices = own_buffer_tensor.AsBlockSparse().Indices();
|
|
+ auto block_sparse = own_buffer_tensor.AsBlockSparse();
|
|
+ const auto& indices = block_sparse.Indices();
|
|
ASSERT_EQ(indices_shape, indices.Shape());
|
|
auto indices_span = indices.DataAsSpan<int32_t>();
|
|
ASSERT_TRUE(std::equal(blocksparse_indices.cbegin(), blocksparse_indices.cend(),
|
|
--
|
|
2.41.0
|