home-assistant
/
open-zwave
mirror of https://github.com/home-assistant/open-zwave.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
open-zwave/cpp
History
Peter Gebruers 2cd2137025 Fix comparison uint8 with -1, also test if controller node is 0. (#16) 
Ported from OZW 1.6 to OZW 1.4 HASS fork.

lldb complained:
Driver.cpp:2701:43: error:
      result of comparison of constant -1 with expression of type
      'uint8' (aka 'unsigned char') is always false
      [-Werror,-Wtautological-constant-out-of-range-compare]

Add some info to debug logging

Add -std=c++11 to fix build error on macOS Catalina, lldb complained:

open-zwave/cpp/src/command_classes/ManufacturerProprietary.h:52:48: error:
      'override' keyword is a C++11 extension

Amends:

commit e326120467
Author: Justin Hammond <justin@dynam.ac>
Date:   Mon Dec 2 22:39:15 2019 +0800

    Check for Invalid HomeID or Controller Node ID's (#10)

    ModemManager on the Host is known to interfere with OZW, and cause problems when starting up. Users will often get messages about "Out of Frame Flow" in OZW_Log.txt. See https://github.com/home-assistant/home-assistant/issues/21165 for example.

    One of the more bizarre side effects of this, is that it causes issues with OZW initializing and a side effect is Node 255 (Broadcast) address will be added to all Associations on devices. This causes weird issues such as a switch triggering every Z-Wave Node in the network etc.

    This check will bail out if we receive a invalid HomeID or Controller Node ID when starting up and stop OZW from inadvertently adding this broadcast address to all node associations.

Fixes https://github.com/OpenZWave/open-zwave/issues/1883

Tested on macOS Catalina and Debian 8 (Jessie), released 25–26 April 2015. Not tested on Debian 7 (Wheezy), released 4 May 2013 because Wheezy does not come with C++11 compiler by default.
 		2019-12-08 12:02:17 +01:00
..
build Fix comparison uint8 with -1, also test if controller node is 0. (#16) 2019-12-08 12:02:17 +01:00
examples Check for Mojave or greater for x86_64-only build 2018-10-02 09:28:11 -07:00
hidapi Support building on SmartOS 2018-07-17 12:48:22 -04:00
src Fix comparison uint8 with -1, also test if controller node is 0. (#16) 2019-12-08 12:02:17 +01:00
tinyxml Add support for passing CPPFLAGS to Makefiles 2015-11-07 11:20:08 +01:00