matrix.org/static/jira/browse/SYWEB-245

103 lines
6.8 KiB
Plaintext

---
summary: Message causes sanitizer to break.
---
created: 2014-12-28 17:44:45.0
creator: erikj
description: |-
The message that broke it was:
{noformat}
{
"content": {
"body": "Blocked loading mixed active content \"http://matrix.org:8090/_matrix/identity/api/v1/validate/email/requestToken\"[Learn More] angular.js:9636\nException { message: \"\", result: 2153644038, name: \"\", filename: \"https://syndica.de:8448/_matrix/client/lib/angular.js\", lineNumber: 9636, columnNumber: 0, inner: null, data: null, stack: \"createHttpBackend/<@https://syndica.de:8448/_matrix/client/lib/angular.js:9636:6\nsendReq@https://syndica.de:8448/_matrix/client/lib/angular.js:9501:0\n$http/serverRequest@https://syndica.de:8448/_matrix/client/lib/angular.js:9218:15\nprocessQueue@https://syndica.de:8448/_matrix/client/lib/angular.js:12988:26\nscheduleProcessQueue/<@https://syndica.de:8448/_matrix/client/lib/angular.js:13004:26\n$RootScopeProvider/this.$get</Scope.prototype.$eval@https://syndica.de:8448/_matrix/client/lib/angular.js:14204:15\n$RootScopeProvider/this.$get</Scope.prototype.$digest@https://syndica.de:8448/_matrix/client/lib/angular.js:14020:14\n$RootScopeProvider/this.$get</Scope.prototype.$apply@https://syndica.de:8448/_matrix/client/lib/angular.js:14308:12\nngEventHandler/<@https://syndica.de:8448/_matrix/client/lib/angular.js:22677:16\nm.event.dispatch@https://syndica.de:8448/_matrix/client/lib/jquery-1.11.1.min.js:3:8383\nm.event.add/r.handle@https://syndica.de:8448/_matrix/client/lib/jquery-1.11.1.min.js:3:5121\n\" } angular.js:11413\n\n\"Unknown error: {}\"",
"msgtype": "m.text"
},
"event_id": "$141978833236DsnQz:syndica.de",
"origin_server_ts": 1419788332326,
"room_id": "!cURbafjkfsMDVwdRDQ:matrix.org",
"type": "m.room.message",
"user_id": "@marcus:syndica.de"
}
{noformat}
with the error:
{noformat}
Error: [$sanitize:badparse] <a target="_blank" href="http://matrix.org:8090/_matrix/identity/api/v1/validate/email/requestToken"[Learn">http://matrix.org:8090/_matrix/identity/api/v1/validate/email/requestToken&#34;[Learn</a> More] angular.js:9636&#10;Exception { message: &#34;&#34;, result: 2153644038, name: &#34;&#34;, filename: &#34;<a target="_blank" href="https://syndica.de:8448/_matrix/client/lib/angular.js">https://syndica.de:8448/_matrix/client/lib/angular.js</a>&#34;, lineNumber: 9636, columnNumber: 0, inner: null, data: null, stack: &#34;createHttpBackend/&lt;@<a target="_blank" href="https://syndica.de:8448/_matrix/client/lib/angular.js:9636:6">https://syndica.de:8448/_matrix/client/lib/angular.js:9636:6</a>&#10;<a target="_blank" href="mailto:sendReq@https://syndica.de:8448/_matrix/client/lib/angular.js:9501:0">sendReq@https://syndica.de:8448/_matrix/client/lib/angular.js:9501:0</a>&#10;$http/<a target="_blank" href="mailto:serverRequest@https://syndica.de:8448/_matrix/client/lib/angular.js:9218:15">serverRequest@https://syndica.de:8448/_matrix/client/lib/angular.js:9218:15</a>&#10;<a target="_blank" href="mailto:processQueue@https://syndica.de:8448/_matrix/client/lib/angular.js:12988:26">processQueue@https://syndica.de:8448/_matrix/client/lib/angular.js:12988:26</a>&#10;scheduleProcessQueue/&lt;@<a target="_blank" href="https://syndica.de:8448/_matrix/client/lib/angular.js:13004:26">https://syndica.de:8448/_matrix/client/lib/angular.js:13004:26</a>&#10;$RootScopeProvider/this.$get&lt;/Scope.prototype.$<a target="_blank" href="mailto:eval@https://syndica.de:8448/_matrix/client/lib/angular.js:14204:15">eval@https://syndica.de:8448/_matrix/client/lib/angular.js:14204:15</a>&#10;$RootScopeProvider/this.$get&lt;/Scope.prototype.$<a target="_blank" href="mailto:digest@https://syndica.de:8448/_matrix/client/lib/angular.js:14020:14">digest@https://syndica.de:8448/_matrix/client/lib/angular.js:14020:14</a>&#10;$RootScopeProvider/this.$get&lt;/Scope.prototype.$<a target="_blank" href="mailto:apply@https://syndica.de:8448/_matrix/client/lib/angular.js:14308:12">apply@https://syndica.de:8448/_matrix/client/lib/angular.js:14308:12</a>&#10;ngEventHandler/&lt;@<a target="_blank" href="https://syndica.de:8448/_matrix/client/lib/angular.js:22677:16">https://syndica.de:8448/_matrix/client/lib/angular.js:22677:16</a>&#10;<a target="_blank" href="mailto:m.event.dispatch@https://syndica.de:8448/_matrix/client/lib/jquery-1.11.1.min.js:3:8383">m.event.dispatch@https://syndica.de:8448/_matrix/client/lib/jquery-1.11.1.min.js:3:8383</a>&#10;m.event.add/<a target="_blank" href="mailto:r.handle@https://syndica.de:8448/_matrix/client/lib/jquery-1.11.1.min.js:3:5121">r.handle@https://syndica.de:8448/_matrix/client/lib/jquery-1.11.1.min.js:3:5121</a>&#10;&#34; } angular.js:11413&#10;&#10;&#34;Unknown error: {}&#34;
http://errors.angularjs.org/1.3.3/$sanitize/badparse
at angular.js:63
at G (angular-sanitize.min.js:8)
at angular-sanitize.min.js:14
at angular-sanitize.min.js:15
at $parseFilter (angular.js:11959)
at $parseTernary (angular.js:12002)
at Object.expressionInputWatch (angular.js:12553)
at Scope.$digest (angular.js:14038)
at Scope.$apply (angular.js:14308)
at angular.js:16039
{noformat}
which seems to happen on every digest :(
id: '10886'
key: SYWEB-245
number: '245'
priority: '1'
project: '10004'
reporter: erikj
resolution: '1'
resolutiondate: 2015-01-02 16:55:33.0
status: '5'
type: '1'
updated: 2015-06-01 09:47:19.0
votes: '0'
watches: '2'
workflowId: '10986'
---
actions:
- author: erikj
body: The visible effect was that the message appeared blank.
created: 2014-12-28 17:45:57.0
id: '11033'
issue: '10886'
type: comment
updateauthor: erikj
updated: 2014-12-28 17:45:57.0
- author: kegan
body: What are the repro conditions here? I'm confused because I see event JSON at the top but the trace is from the identity server. It sounds like it's refusing to do the HTTP poke, probably because the web client is on HTTPS?
created: 2014-12-29 09:21:05.0
id: '11034'
issue: '10886'
type: comment
updateauthor: kegan
updated: 2014-12-29 09:21:05.0
- author: erikj
body: |-
Has this been released yet? I have another example in case it has and it hasn't fixed all cases:
{noformat}
{
"content": {
"body": "alice@example.org => {\"smtp\":[\"alice@example.org\"], \"sip\":[\"callalice@blah.com\"], ...}",
"msgtype": "m.text"
},
"event_id": "$1420672504542cZHXE:matrix.org",
"origin_server_ts": 1420672504988,
"room_id": "!cURbafjkfsMDVwdRDQ:matrix.org",
"type": "m.room.message",
"user_id": "@irc_elijh:matrix.org"
}
{noformat}
created: 2015-01-07 23:18:10.0
id: '11063'
issue: '10886'
type: comment
updateauthor: erikj
updated: 2015-01-07 23:18:10.0
- author: kegan
body: Not released yet; fixed on develop.
created: 2015-01-08 09:31:11.0
id: '11064'
issue: '10886'
type: comment
updateauthor: kegan
updated: 2015-01-08 09:31:11.0