386 lines
13 KiB
JavaScript
386 lines
13 KiB
JavaScript
// @ts-check
|
|
|
|
import eslint from '@eslint/js';
|
|
import comments from '@eslint-community/eslint-plugin-eslint-comments/configs';
|
|
import compat from 'eslint-plugin-compat';
|
|
import globals from 'globals';
|
|
// @ts-expect-error Missing type definition
|
|
import importPlugin from 'eslint-plugin-import';
|
|
import jsxA11y from 'eslint-plugin-jsx-a11y';
|
|
import reactPlugin from 'eslint-plugin-react';
|
|
import reactHooks from 'eslint-plugin-react-hooks';
|
|
import restrictedGlobals from 'confusing-browser-globals';
|
|
import sonarjs from 'eslint-plugin-sonarjs';
|
|
import stylistic from '@stylistic/eslint-plugin';
|
|
// eslint-disable-next-line import/no-unresolved
|
|
import tseslint from 'typescript-eslint';
|
|
|
|
export default tseslint.config(
|
|
eslint.configs.recommended,
|
|
tseslint.configs.recommended,
|
|
// @ts-expect-error Harmless type mismatch in dependency
|
|
comments.recommended,
|
|
compat.configs['flat/recommended'],
|
|
importPlugin.flatConfigs.errors,
|
|
sonarjs.configs.recommended,
|
|
|
|
reactPlugin.configs.flat.recommended,
|
|
{
|
|
settings: {
|
|
react: {
|
|
version: 'detect'
|
|
}
|
|
}
|
|
},
|
|
jsxA11y.flatConfigs.recommended,
|
|
|
|
// Global ignores
|
|
{
|
|
ignores: [
|
|
'node_modules',
|
|
'coverage',
|
|
'dist',
|
|
'.idea',
|
|
'.vscode'
|
|
]
|
|
},
|
|
|
|
// Global style rules
|
|
{
|
|
plugins: {
|
|
'@stylistic': stylistic
|
|
},
|
|
extends: [ importPlugin.flatConfigs.typescript ],
|
|
rules: {
|
|
'array-callback-return': ['error', { 'checkForEach': true }],
|
|
'curly': ['error', 'multi-line', 'consistent'],
|
|
'default-case-last': 'error',
|
|
'max-params': ['error', 7],
|
|
'new-cap': [
|
|
'error',
|
|
{
|
|
'capIsNewExceptions': ['jQuery.Deferred'],
|
|
'newIsCapExceptionPattern': '\\.default$'
|
|
}
|
|
],
|
|
'no-duplicate-imports': 'error',
|
|
'no-empty-function': 'error',
|
|
'no-extend-native': 'error',
|
|
'no-lonely-if': 'error',
|
|
'no-nested-ternary': 'error',
|
|
'no-redeclare': 'off',
|
|
'@typescript-eslint/no-redeclare': ['error', { builtinGlobals: false }],
|
|
'no-restricted-globals': ['error'].concat(restrictedGlobals),
|
|
'no-return-assign': 'error',
|
|
'no-return-await': 'error',
|
|
'no-sequences': ['error', { 'allowInParentheses': false }],
|
|
'no-shadow': 'off',
|
|
'@typescript-eslint/no-shadow': 'error',
|
|
'no-throw-literal': 'error',
|
|
'no-undef-init': 'error',
|
|
'no-unneeded-ternary': 'error',
|
|
'no-unused-expressions': 'off',
|
|
'@typescript-eslint/no-unused-expressions': ['error', { 'allowShortCircuit': true, 'allowTernary': true, 'allowTaggedTemplates': true }],
|
|
'no-unused-private-class-members': 'error',
|
|
'@typescript-eslint/no-unused-vars': 'error',
|
|
'no-useless-rename': 'error',
|
|
'no-useless-constructor': 'off',
|
|
'@typescript-eslint/no-useless-constructor': 'error',
|
|
'no-var': 'error',
|
|
'no-void': ['error', { 'allowAsStatement': true }],
|
|
'no-warning-comments': ['warn', { 'terms': ['hack', 'xxx'] }],
|
|
'one-var': ['error', 'never'],
|
|
'prefer-const': ['error', { 'destructuring': 'all' }],
|
|
'prefer-promise-reject-errors': ['warn', { 'allowEmptyReject': true }],
|
|
'@typescript-eslint/prefer-for-of': 'error',
|
|
'radix': 'error',
|
|
'yoda': 'error',
|
|
|
|
'sonarjs/fixme-tag': 'warn',
|
|
'sonarjs/todo-tag': 'off',
|
|
'sonarjs/deprecation': 'warn',
|
|
'sonarjs/no-alphabetical-sort': 'warn',
|
|
'sonarjs/no-inverted-boolean-check': 'error',
|
|
'sonarjs/no-selector-parameter': 'off',
|
|
'sonarjs/pseudo-random': 'warn',
|
|
// TODO: Enable the following sonarjs rules and fix issues
|
|
'sonarjs/no-duplicate-string': 'off',
|
|
'sonarjs/no-nested-functions': 'warn',
|
|
|
|
// TODO: Replace with stylistic.configs.customize()
|
|
'@stylistic/block-spacing': 'error',
|
|
'@stylistic/brace-style': ['error', '1tbs', { 'allowSingleLine': true }],
|
|
'@stylistic/comma-dangle': ['error', 'never'],
|
|
'@stylistic/comma-spacing': 'error',
|
|
'@stylistic/eol-last': 'error',
|
|
'@stylistic/indent': ['error', 4, { 'SwitchCase': 1 }],
|
|
'@stylistic/jsx-quotes': ['error', 'prefer-single'],
|
|
'@stylistic/keyword-spacing': 'error',
|
|
'@stylistic/max-statements-per-line': 'error',
|
|
'@stylistic/no-floating-decimal': 'error',
|
|
'@stylistic/no-mixed-spaces-and-tabs': 'error',
|
|
'@stylistic/no-multi-spaces': 'error',
|
|
'@stylistic/no-multiple-empty-lines': ['error', { 'max': 1 }],
|
|
'@stylistic/no-trailing-spaces': 'error',
|
|
'@stylistic/object-curly-spacing': ['error', 'always'],
|
|
'@stylistic/operator-linebreak': ['error', 'before', { overrides: { '?': 'after', ':': 'after', '=': 'after' } }],
|
|
'@stylistic/padded-blocks': ['error', 'never'],
|
|
'@stylistic/quotes': ['error', 'single', { 'avoidEscape': true, 'allowTemplateLiterals': false }],
|
|
'@stylistic/semi': 'error',
|
|
'@stylistic/space-before-blocks': 'error',
|
|
'@stylistic/space-infix-ops': 'error'
|
|
}
|
|
},
|
|
|
|
// Config files use node globals
|
|
{
|
|
ignores: [ 'src' ],
|
|
languageOptions: {
|
|
globals: {
|
|
...globals.node
|
|
}
|
|
}
|
|
},
|
|
|
|
// Config files are commonjs by default
|
|
{
|
|
files: [ '**/*.{cjs,js}' ],
|
|
ignores: [ 'src' ],
|
|
languageOptions: {
|
|
sourceType: 'commonjs'
|
|
},
|
|
rules: {
|
|
'@typescript-eslint/no-require-imports': 'off'
|
|
}
|
|
},
|
|
|
|
// App files
|
|
{
|
|
files: [
|
|
'src/**/*.{js,jsx,ts,tsx}'
|
|
],
|
|
languageOptions: {
|
|
parserOptions: {
|
|
projectService: true,
|
|
tsconfigRootDir: import.meta.dirname
|
|
},
|
|
globals: {
|
|
...globals.browser,
|
|
// Tizen globals
|
|
'tizen': false,
|
|
'webapis': false,
|
|
// WebOS globals
|
|
'webOS': false,
|
|
// Dependency globals
|
|
'$': false,
|
|
'jQuery': false,
|
|
// Jellyfin globals
|
|
'ApiClient': true,
|
|
'Events': true,
|
|
'chrome': true,
|
|
'Emby': false,
|
|
'Hls': true,
|
|
'LibraryMenu': true,
|
|
'Windows': false,
|
|
// Build time definitions
|
|
__COMMIT_SHA__: false,
|
|
__JF_BUILD_VERSION__: false,
|
|
__PACKAGE_JSON_NAME__: false,
|
|
__PACKAGE_JSON_VERSION__: false,
|
|
__USE_SYSTEM_FONTS__: false,
|
|
__WEBPACK_SERVE__: false
|
|
}
|
|
},
|
|
settings: {
|
|
'import/resolver': {
|
|
node: {
|
|
extensions: [
|
|
'.js',
|
|
'.ts',
|
|
'.jsx',
|
|
'.tsx'
|
|
],
|
|
moduleDirectory: [
|
|
'node_modules',
|
|
'src'
|
|
]
|
|
}
|
|
},
|
|
polyfills: [
|
|
'Promise',
|
|
// whatwg-fetch
|
|
'fetch',
|
|
// document-register-element
|
|
'document.registerElement',
|
|
// resize-observer-polyfill
|
|
'ResizeObserver',
|
|
// fast-text-encoding
|
|
'TextEncoder',
|
|
// intersection-observer
|
|
'IntersectionObserver',
|
|
// Core-js
|
|
'Object.assign',
|
|
'Object.is',
|
|
'Object.setPrototypeOf',
|
|
'Object.toString',
|
|
'Object.freeze',
|
|
'Object.seal',
|
|
'Object.preventExtensions',
|
|
'Object.isFrozen',
|
|
'Object.isSealed',
|
|
'Object.isExtensible',
|
|
'Object.getOwnPropertyDescriptor',
|
|
'Object.getPrototypeOf',
|
|
'Object.keys',
|
|
'Object.entries',
|
|
'Object.getOwnPropertyNames',
|
|
'Function.name',
|
|
'Function.hasInstance',
|
|
'Array.from',
|
|
'Array.arrayOf',
|
|
'Array.copyWithin',
|
|
'Array.fill',
|
|
'Array.find',
|
|
'Array.findIndex',
|
|
'Array.iterator',
|
|
'String.fromCodePoint',
|
|
'String.raw',
|
|
'String.iterator',
|
|
'String.codePointAt',
|
|
'String.endsWith',
|
|
'String.includes',
|
|
'String.repeat',
|
|
'String.startsWith',
|
|
'String.trim',
|
|
'String.anchor',
|
|
'String.big',
|
|
'String.blink',
|
|
'String.bold',
|
|
'String.fixed',
|
|
'String.fontcolor',
|
|
'String.fontsize',
|
|
'String.italics',
|
|
'String.link',
|
|
'String.small',
|
|
'String.strike',
|
|
'String.sub',
|
|
'String.sup',
|
|
'RegExp',
|
|
'Number',
|
|
'Math',
|
|
'Date',
|
|
'async',
|
|
'Symbol',
|
|
'Map',
|
|
'Set',
|
|
'WeakMap',
|
|
'WeakSet',
|
|
'ArrayBuffer',
|
|
'DataView',
|
|
'Int8Array',
|
|
'Uint8Array',
|
|
'Uint8ClampedArray',
|
|
'Int16Array',
|
|
'Uint16Array',
|
|
'Int32Array',
|
|
'Uint32Array',
|
|
'Float32Array',
|
|
'Float64Array',
|
|
'Reflect'
|
|
]
|
|
},
|
|
rules: {
|
|
// TODO: Add typescript recommended typed rules
|
|
'@typescript-eslint/naming-convention': [
|
|
'error',
|
|
{
|
|
selector: 'default',
|
|
format: [ 'camelCase', 'PascalCase' ],
|
|
leadingUnderscore: 'allow'
|
|
},
|
|
{
|
|
selector: 'variable',
|
|
format: [ 'camelCase', 'PascalCase', 'UPPER_CASE' ],
|
|
leadingUnderscore: 'allowSingleOrDouble',
|
|
trailingUnderscore: 'allowSingleOrDouble'
|
|
},
|
|
{
|
|
selector: 'typeLike',
|
|
format: [ 'PascalCase' ]
|
|
},
|
|
{
|
|
selector: 'enumMember',
|
|
format: [ 'PascalCase', 'UPPER_CASE' ]
|
|
},
|
|
{
|
|
selector: [ 'objectLiteralProperty', 'typeProperty' ],
|
|
format: [ 'camelCase', 'PascalCase' ],
|
|
leadingUnderscore: 'allowSingleOrDouble',
|
|
trailingUnderscore: 'allowSingleOrDouble'
|
|
},
|
|
// Ignore numbers, locale strings (en-us), aria/data attributes, CSS selectors,
|
|
// and api_key parameter
|
|
{
|
|
selector: [ 'objectLiteralProperty', 'typeProperty' ],
|
|
format: null,
|
|
filter: {
|
|
regex: '[ &\\-]|^([0-9]+)$|^api_key$',
|
|
match: true
|
|
}
|
|
}
|
|
],
|
|
'@typescript-eslint/no-floating-promises': 'error',
|
|
'@typescript-eslint/prefer-string-starts-ends-with': 'error'
|
|
}
|
|
},
|
|
|
|
// React files
|
|
{
|
|
files: [ 'src/**/*.{jsx,tsx}' ],
|
|
plugins: {
|
|
'react-hooks': reactHooks
|
|
},
|
|
rules: {
|
|
'react/jsx-filename-extension': ['error', { 'extensions': ['.jsx', '.tsx'] }],
|
|
'react/jsx-no-bind': 'error',
|
|
'react/jsx-no-useless-fragment': 'error',
|
|
'react/no-array-index-key': 'error',
|
|
'react-hooks/rules-of-hooks': 'error',
|
|
'react-hooks/exhaustive-deps': 'warn'
|
|
}
|
|
},
|
|
|
|
// Service worker
|
|
{
|
|
files: [ 'src/serviceworker.js' ],
|
|
languageOptions: {
|
|
globals: {
|
|
...globals.serviceworker
|
|
}
|
|
}
|
|
},
|
|
|
|
// Legacy JS (less strict)
|
|
{
|
|
files: [ 'src/**/*.{js,jsx}' ],
|
|
rules: {
|
|
'@typescript-eslint/no-floating-promises': 'off',
|
|
'@typescript-eslint/no-this-alias': 'off',
|
|
'@typescript-eslint/no-unused-vars': 'warn',
|
|
|
|
'sonarjs/public-static-readonly': 'off',
|
|
|
|
// TODO: Enable the following rules and fix issues
|
|
'sonarjs/cognitive-complexity': 'off',
|
|
'sonarjs/constructor-for-side-effects': 'off',
|
|
'sonarjs/function-return-type': 'off',
|
|
'sonarjs/no-async-constructor': 'off',
|
|
'sonarjs/no-duplicate-string': 'off',
|
|
'sonarjs/no-ignored-exceptions': 'off',
|
|
'sonarjs/no-invariant-returns': 'warn',
|
|
'sonarjs/no-nested-functions': 'off',
|
|
'sonarjs/void-use': 'off'
|
|
}
|
|
}
|
|
);
|