pulumi/pkg/codegen/go/gen_spill.go

76 lines
1.5 KiB
Go
Raw Normal View History

package gen
import (
"fmt"
"github.com/hashicorp/hcl/v2"
"github.com/pulumi/pulumi/pkg/v3/codegen/hcl2/model"
)
type spillFunc func(x model.Expression) (string, model.Expression, bool)
type spillTemp struct {
Kind string
Variable *model.Variable
Value model.Expression
}
type spills struct {
counts map[string]int
}
func (s *spills) newTemp(kind string, value model.Expression) *spillTemp {
i := s.counts[kind]
s.counts[kind] = i + 1
v := &model.Variable{
Name: fmt.Sprintf("%s%d", kind, i),
VariableType: value.Type(),
}
return &spillTemp{
Variable: v,
Value: value,
}
}
type spiller struct {
spills *spills
temps []*spillTemp
spill spillFunc
disabled bool
}
func (s *spiller) preVisit(x model.Expression) (model.Expression, hcl.Diagnostics) {
_, isfn := x.(*model.AnonymousFunctionExpression)
if isfn {
s.disabled = true
}
return x, nil
}
func (s *spiller) postVisit(x model.Expression) (model.Expression, hcl.Diagnostics) {
_, isfn := x.(*model.AnonymousFunctionExpression)
if isfn {
s.disabled = false
} else if !s.disabled {
if kind, value, ok := s.spill(x); ok {
t := s.spills.newTemp(kind, value)
s.temps = append(s.temps, t)
return model.VariableReference(t.Variable), nil
}
}
return x, nil
}
func (g *generator) rewriteSpills(
all: Reformat with gofumpt Per team discussion, switching to gofumpt. [gofumpt][1] is an alternative, stricter alternative to gofmt. It addresses other stylistic concerns that gofmt doesn't yet cover. [1]: https://github.com/mvdan/gofumpt See the full list of [Added rules][2], but it includes: - Dropping empty lines around function bodies - Dropping unnecessary variable grouping when there's only one variable - Ensuring an empty line between multi-line functions - simplification (`-s` in gofmt) is always enabled - Ensuring multi-line function signatures end with `) {` on a separate line. [2]: https://github.com/mvdan/gofumpt#Added-rules gofumpt is stricter, but there's no lock-in. All gofumpt output is valid gofmt output, so if we decide we don't like it, it's easy to switch back without any code changes. gofumpt support is built into the tooling we use for development so this won't change development workflows. - golangci-lint includes a gofumpt check (enabled in this PR) - gopls, the LSP for Go, includes a gofumpt option (see [installation instrutions][3]) [3]: https://github.com/mvdan/gofumpt#installation This change was generated by running: ```bash gofumpt -w $(rg --files -g '*.go' | rg -v testdata | rg -v compilation_error) ``` The following files were manually tweaked afterwards: - pkg/cmd/pulumi/stack_change_secrets_provider.go: one of the lines overflowed and had comments in an inconvenient place - pkg/cmd/pulumi/destroy.go: `var x T = y` where `T` wasn't necessary - pkg/cmd/pulumi/policy_new.go: long line because of error message - pkg/backend/snapshot_test.go: long line trying to assign three variables in the same assignment I have included mention of gofumpt in the CONTRIBUTING.md.
2023-03-03 16:36:39 +00:00
x model.Expression, spill spillFunc,
) (model.Expression, []*spillTemp, hcl.Diagnostics) {
spiller := &spiller{
spills: g.spills,
spill: spill,
}
x, diags := model.VisitExpression(x, spiller.preVisit, spiller.postVisit)
return x, spiller.temps, diags
}