Commit Graph

20 Commits

Author SHA1 Message Date
Zaid Ajaj 91bcce199a
Revert "[sdk-gen/go] Fix compiling plain element type with plain maps" ()
Reverts pulumi/pulumi#14704 

Fixes  because the PR above changed how object types are
referenced when they are plain. It seems that we only support _shallow_
plain types (only container of nested objects can be plain, not the
object itself) which is why we confused the previous diffs to be
correct.

This reverts the PR previous to fix the breaking change at hand but will
reopen  and make sure the fix for it is to generate `ObjectType`
_and_ `ObjectTypeArgs` regardless of whether the location where the
object type is referenced in the schema.
2024-01-05 15:22:41 +00:00
Zaid Ajaj 6ea13f92ac
[sdk-gen/go] Fix generated usage documentation for enum input types ()
# Description

Fixes  (issue)

## Checklist

- [ ] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2023-12-12 17:52:25 +00:00
Zaid Ajaj c47cf5e2cd
[sdk-gen/go] Fix compiling plain element type with plain maps ()
# Description

Fixes  when choosing whether to use `ObjectName` (plain) or
`ObjectNameArgs` (non-plain) we have to check whether the non-plain
version was actually available in first place (sometimes it isn't when
the type isn't used anywhere as non-plain) so the fix here is to use the
package context that tracks the usages to determine whether the `Args`
suffix should be used.

Funny though, for other languages like C#, TypeScript and Python we
don't have a concept of a strictly plain type. Instead all types are
non-plain (accepting values for their properties being inputs/outputs)
which means that a plain element type on maps for these languages has no
effect

## Checklist

- [ ] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2023-12-04 12:34:40 +00:00
Anton Tayanovskyy ba039c20f8
Support returning plain values from methods ()
Support returning plain values from methods.

Implements Node, Python and Go support.

Remaining:

- [x] test receiving unknowns
- [x] acceptance tests written and passing locally for Node, Python, Go
clients against a Go server
- [x] acceptance tests passing in CI
- [x] tickets filed for remaining languages
   - [x] https://github.com/pulumi/pulumi-yaml/issues/499
   - [x] https://github.com/pulumi/pulumi-java/issues/1193
   - [x] https://github.com/pulumi/pulumi-dotnet/issues/170 

Known limitations:

- this is technically a breaking change in case there is code out there
that already uses methods that return Plain: true

- struct-wrapping limitation: the provider for the component resource
needs to still wrap the plain-returning Method response with a 1-arg
struct; by convention the field is named "res", and this is how it
travels through the plumbing

- resources cannot return plain values yet

- the provider for the component resource cannot have unknown
configuration, if it does, the methods will not be called
- Per Luke https://github.com/pulumi/pulumi/issues/11520 this might not
be supported/realizable yet

<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. -->

Fixes https://github.com/pulumi/pulumi/issues/12709

## Checklist

- [ ] I have run `make tidy` to update any new dependencies
- [ ] I have run `make lint` to verify my code passes the lint check
  - [ ] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2023-11-18 06:02:06 +00:00
Zaid Ajaj a28454477c
[go/sdk-gen] Generating SDK with generics ()
# Description

This PR implements generating the generic variant of a go SDK from
Pulumi schemas. Currently the idea is to generate a directory `x` inside
the root directory of the go SDK which will contain the same SDK except
using generics and generating far less code than its current counter
part.

Also implements an enum option `$.language.go.generics` which can be set
to the following:
- `none` is the default which maintains the current behavior that
generates legacy types without generics
- `side-by-side` generates the generics sdk variant alongside the
current sdk under directory `x`
- `generics-only` generates only the new sdk with generics at the root
of the package
 
Still a bunch of things to do:
- [x] Generating `InvokeResult]Output` type from `Output[InvokeResult]`
and generating accessor methods for it
- [x] Generating default values for types and using the `pulumix`
subpackage to do so
- [x] Generating generic SDK variants for all test schemas we have and
making sure they compile (currently only testing
`simple-resource-schema` as shown below)
 - [x] Account for plain inputs for components
- [x] Combine pulumix.Join with pulumix.Apply to generate resource
accessor methods
- [x] Problem with `GPtrOutput[T]` and `ArrayOutput[T]` being unwrapped
to `Output[*T]` and `Output[[]T]`
 - [x] Remove excess untyped container types from generated enums
- [x] Fix default values for resource methods with lifted single return
value
 - [x] Secret properties

Currently the following test schemas have opted for `generics:
"side-by-side"`:
 - [x] output-funcs
 - [x] simple-enum-schema
 - [x] secrets
 - [x] simple-plain-schema
 - [x] plain-and-default

## Checklist

- [ ] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [ ] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2023-09-19 10:28:50 +00:00
Abhinav Gupta 025add9c3e
codegen/go: Implement pux.Input[T] for generated types ()
For generated types that impleemnt `pulumi.Output`,
or those that implement `pulumi.Input` with a means of converting
themselves to a `pulumi.Output`,
also generate `ToOutput(context.Context) pux.Output[..]`
to satisfy the `pux.Input[T]` interface.

This allows all these generated types to be used with `pux.Apply`
and other type-safe generic APIs per .

Resolves 
2023-08-28 16:42:37 +00:00
Guinevere Saenger 6351e34c77 Generate new tests 2023-06-14 09:34:49 -07:00
Abhinav Gupta 66df210087
chore(codegen/testing): Regenerate all code
Regenerates code in codegen/testing based on changes
made to fix .
2023-05-19 11:53:55 -07:00
Fraser Waters 74e2b45157 Consistently set (or not) respectSchemaVersion 2023-03-26 15:56:35 +01:00
Ian Wahbe e15d0c5ea0 Use `nil` checks when appropriate
Regnerate tests

Add behavior test
2023-02-08 16:38:37 -08:00
Fraser Waters 50966686bc Use 'errors' not 'pkg/errors' in go codegen 2023-02-02 15:42:05 +00:00
Fraser Waters d8f310921c codegen/go: Remove superfluous newline in doc.go
This change fixes the package documentation comment generation that was
broken since .
2022-11-30 14:17:13 +00:00
Aaron Friel a4b1d6b2a7 ci: gofmt 1.18+ clean 2022-09-21 09:48:39 -07:00
Paul Stack f4f5f808b6
codegen/go: Remove superfluous double forward slash in doc.go () 2022-08-08 15:36:31 +01:00
Aaron Friel 10747fa192
[sdk/go] Enable obtaining resource outputs off a ResourceOutput ()
* [codegen] add chain functions for resource outputs

* [sdk/go] Allow ApplyT applier to return an Output

* Update CHANGELOG_PENDING.md

Co-authored-by: Ian Wahbe <ian@wahbe.com>
2022-05-03 11:36:57 -07:00
Ian Wahbe a5d728f376
Shallow Plain Types ()
* Shallow schema + attempt defaults

As a caviat, defaults are not handled for nested Inputty types.

* Update tests

* Update CHANGELOG_PENDING.md
2022-05-03 11:13:21 -07:00
Ian Wahbe 9215392483
Fix TS name generation for names that start with `_` ()
* Add test case

* Correctly import plain types

* Update tests

* Update type_driver tests

* Update CHANGELOG_PENDING.md

* Fix TS enum names

* Extend simple-enum-schema test to cover edge case

* Small code cleanup
2022-05-02 11:16:21 -07:00
Ian Wahbe 68267e1823
Idiomatic Go: generated code message ()
* Idiomatic autogenerated message for go SDK

By convention, as outlined in
https://pkg.go.dev/cmd/go#hdr-Generate_Go_files_by_processing_source,
autogenerated go source code includes a regexp that matches
`^// Code generated .* DO NOT EDIT\.$`. I have changed our go
autogenerated message to comply and added a test on our generated
header.

* Update test results

* Mark test as parallel

* Fix nit
2022-04-19 18:39:23 +02:00
Luke Hoban 6a9106d626
[codegen/go] Don't error for 3rd party Go SDKs - assume v1 default instead ()
* Default to `v1` instead of error in PkgVersion

* Set PULUMI_ACCEPT=true and regenerate test outputs

* Default PkgVersion to 1.0.0 if no version is found

* Generated change

Co-authored-by: Levi Blackstone <levi@pulumi.com>
Co-authored-by: Ian Wahbe <ian@wahbe.com>
2022-03-02 11:57:33 -08:00
Ian Wahbe a1e18dae4d
export codegen tests for internal use ()
* Export Codegen test modules

* Document pkg stability guarantee

* Expose programgen

* Recommendation: Improve wording

* Move `internal` to `testing`

* Re-rout references to codegen/internal

* Fix some other "internal" references
2022-02-07 12:10:04 +01:00