These secrets are required for the acceptance tests to run correctly, as
we're getting false failures otherwise. This is safe, since we're also
using these secrets in other CI jobs, and always review code before
running the acceptance tests.
I noticed in https://github.com/pulumi/pulumi/pull/15173 that the tests
introduced in https://github.com/pulumi/pulumi/pull/14649 are failing.
We currently upload coverage artifacts to codecov every 12 hours via the periodic-coverage cron workflow, which runs the full suite of tests against master, as well as during PRs, which runs a subset of tests for the PR.
We currently see some discrepancies in the data in codecov. One theory is the difference in tests between PRs and master.
This change makes it so we no longer upload coverage artifacts during PRs, to helpfully keep the data in codecov clean for trends over time.
After internal discussion, we determined "smoke" is a misleading
adjective for this category of tests. What we called "smoke tests"
are short integration tests for basic cross-platform functionality.
As a result, these are better named "acceptance" tests, since smoke
tests are intended to be a low water mark at the unit level to sniff
out bigger issues with the build as a whole.