Discovered while refactoring, the `raw` argument supplied to a test
utility in the `progress_test` tests was not used.
Fixes the tests in two commits, both of which pass tests. The first
implements the intended refactoring without changing the test behavior.
The second updates the test to use the `raw` parameter and regenerates
test output.
The refactoring is applied in this pull request as a "friendly
amendment" to improve the code before making larger changes to add more
testing options.
The Pulumi CLI supports rendering operations in a number of ways, such
as interactively to the console, or as streams of JSON events. The tree
renderer is one of Pulumi's interactive options, writing trees of parent
and child resources to the terminal as an operation progresses. This
commit pulls out part of #16094 in order to improve the tree renderer in
two ways:
* When the number of lines rendered decreases between renders, old lines
that should no longer be visible must be overwritten. The previous
implementation was buggy in that it did not take system messages into
account when doing this. This commit does.
* When writing system messages, the previous implementation did not trim
output to the terminal width. This commit does.
With no additional changes, these fixes result in changes to the golden
test outputs we maintain as part of the display tests that are not
ASCII-visible. To rectify this and hopefully make these tests more
understandable, this commit also introduces a `mockTermInfo` terminal
info implementation that explicitly prints otherwise-invisible terminal
codes such as "hide cursor", "move cursor up 2 lines" and so on.
Moreover, this commit has been manually testing with a number of real
Pulumi CLI operations to try and avoid breakage of the display.
This PR implements the new policy transforms feature, which allows
policy packs to not only issue warnings and errors in response to policy
violations, but actually fix them by rewriting resource property state.
This can be used, for instance, to auto-tag resources, remove Internet
access on the fly, or apply encryption to storage, among other use
cases.
Switch this to "View in Browser" per discussion
which is closer to the old "View Live" message.
sdk/go/auto doesn't need an update because the regex there
is still using "View in Browser".
Add support for using Ctrl+O to open the current update in the browser
for backends that support permalinks.
The keybinding is advertised in the interactive display as part of the
message that displays the permalink:
```
Previewing update (dev)
View in Browser (Ctrl+O): https://<some-url>
Type Name Plan
+ pulumi:pulumi:Stack vpc-dev create
+ ├─ aws:ec2:Vpc vpc create
+ ├─ aws:ec2:SecurityGroup secgroup create
+ ├─ aws:ec2:SecurityGroupRule rule-2 create
+ ├─ aws:ec2:SecurityGroupRule rule-0 create
+ ├─ aws:ec2:SecurityGroupRule rule-1 create
+ └─ aws:ec2:SecurityGroupRule rule-3 create
```
In order to maintain backwards compatibility with older versions of the
Automation API, the message is not changed for non-interactive
scenarios.
Replace direct interaction with the terminal with an abstraction. This
abstraction is tightly constrained to the capabilities needed for the
CLI's display. Using this abstraction allows for straightforward testing
of the interactive renderers.