Commit Graph

5 Commits

Author SHA1 Message Date
Will Jones 004819228a
Move `sdk/go/common/tools/path` to `pkg` ()
`sdk/go/common/tools/path` is home to some helper functions that relate
to creating test Go environments. Some of this functionality is unused,
and some of it is [only used

internally](https://github.com/search?q=%28org%3Apulumiverse+OR+org%3Apulumi%29+%22CreateTemporaryGoFolder%22&type=code)
and doesn't need to be part of the public API that `sdk/go/common` in
theory comprises. This commit moves it alongside its consumer in `pkg`
to try and reduce unnecessary surface in `sdk/go/common`.
2024-12-02 17:13:30 +00:00
Abhinav Gupta 7aa5b77a0c
all: Reformat with gofumpt
Per team discussion, switching to gofumpt.

[gofumpt][1] is an alternative, stricter alternative to gofmt.
It addresses other stylistic concerns that gofmt doesn't yet cover.

  [1]: https://github.com/mvdan/gofumpt

See the full list of [Added rules][2], but it includes:

- Dropping empty lines around function bodies
- Dropping unnecessary variable grouping when there's only one variable
- Ensuring an empty line between multi-line functions
- simplification (`-s` in gofmt) is always enabled
- Ensuring multi-line function signatures end with
  `) {` on a separate line.

  [2]: https://github.com/mvdan/gofumpt#Added-rules

gofumpt is stricter, but there's no lock-in.
All gofumpt output is valid gofmt output,
so if we decide we don't like it, it's easy to switch back
without any code changes.

gofumpt support is built into the tooling we use for development
so this won't change development workflows.

- golangci-lint includes a gofumpt check (enabled in this PR)
- gopls, the LSP for Go, includes a gofumpt option
  (see [installation instrutions][3])

  [3]: https://github.com/mvdan/gofumpt#installation

This change was generated by running:

```bash
gofumpt -w $(rg --files -g '*.go' | rg -v testdata | rg -v compilation_error)
```

The following files were manually tweaked afterwards:

- pkg/cmd/pulumi/stack_change_secrets_provider.go:
  one of the lines overflowed and had comments in an inconvenient place
- pkg/cmd/pulumi/destroy.go:
  `var x T = y` where `T` wasn't necessary
- pkg/cmd/pulumi/policy_new.go:
  long line because of error message
- pkg/backend/snapshot_test.go:
  long line trying to assign three variables in the same assignment

I have included mention of gofumpt in the CONTRIBUTING.md.
2023-03-03 09:00:24 -08:00
svangordon-fruit 51406fc771
refactor: append to env var list instead of overwriting. () 2022-07-28 08:39:31 +01:00
Aaron Friel ed2923653c ci: radical idea - what if slow tests & no stdout makes GH consider runner dead? 2022-03-06 14:52:13 -08:00
Ian Wahbe aa2368d3c0
Give user defined variables precedence in GetCommandResults ()
* Give user defined variables precedence

* Update CHANGELOG_PENDING.md

* Add unit test to encode desired behavior
2022-01-05 11:03:29 -08:00