Commit Graph

5 Commits

Author SHA1 Message Date
Abhinav Gupta 7aa5b77a0c
all: Reformat with gofumpt
Per team discussion, switching to gofumpt.

[gofumpt][1] is an alternative, stricter alternative to gofmt.
It addresses other stylistic concerns that gofmt doesn't yet cover.

  [1]: https://github.com/mvdan/gofumpt

See the full list of [Added rules][2], but it includes:

- Dropping empty lines around function bodies
- Dropping unnecessary variable grouping when there's only one variable
- Ensuring an empty line between multi-line functions
- simplification (`-s` in gofmt) is always enabled
- Ensuring multi-line function signatures end with
  `) {` on a separate line.

  [2]: https://github.com/mvdan/gofumpt#Added-rules

gofumpt is stricter, but there's no lock-in.
All gofumpt output is valid gofmt output,
so if we decide we don't like it, it's easy to switch back
without any code changes.

gofumpt support is built into the tooling we use for development
so this won't change development workflows.

- golangci-lint includes a gofumpt check (enabled in this PR)
- gopls, the LSP for Go, includes a gofumpt option
  (see [installation instrutions][3])

  [3]: https://github.com/mvdan/gofumpt#installation

This change was generated by running:

```bash
gofumpt -w $(rg --files -g '*.go' | rg -v testdata | rg -v compilation_error)
```

The following files were manually tweaked afterwards:

- pkg/cmd/pulumi/stack_change_secrets_provider.go:
  one of the lines overflowed and had comments in an inconvenient place
- pkg/cmd/pulumi/destroy.go:
  `var x T = y` where `T` wasn't necessary
- pkg/cmd/pulumi/policy_new.go:
  long line because of error message
- pkg/backend/snapshot_test.go:
  long line trying to assign three variables in the same assignment

I have included mention of gofumpt in the CONTRIBUTING.md.
2023-03-03 09:00:24 -08:00
Aaron Friel 94aab9892b
perf: Use a faster check for empty schemas ()
* perf: Use a faster check for empty schemas

* chore: changelog
2022-08-19 07:40:59 -07:00
Aaron Friel 3cd0665a2f
[schema] Faster schema loading via caching alongside plugins ()
* [engine] cache schemas in schema loader to files

* [engine] single instance mmapped schemas, preventing use-after-free segfault

* fix: clean up remaining references to close method

* chore: pr feedback
2022-06-13 23:27:11 -07:00
Mikhail Shilkov 3bed9469f8
Fix the master build with t.Parallel() () 2022-06-02 12:51:33 +02:00
Aaron Friel 9d1a8d521f
[engine] Remove a copy of schema bytes, use regexp over string. ()
* [engine] Remove a copy of schema bytes, use regexp over string.

* simplify regex test with compile
2022-06-01 18:17:06 -07:00