Commit Graph

10 Commits

Author SHA1 Message Date
Fraser Waters b8fd9966a7
When changing parents also fix URNs ()
<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. -->

Fixes https://github.com/pulumi/pulumi/issues/13903
    
When we change parents in a statefile we also need to fix up the URN.
This is needed so aliases can track over partial updates.

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [ ] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2023-09-14 19:52:27 +00:00
Justin Van Patten 4c0b08d8ae
[engine] Check for old resources first by URN and then aliases ()
This change fixes a regression in the step generator when looking for
old resources. When generating steps for a register resource event, we
previously looked for old resources first by the resource's URN and then
by aliases.

This regressed with :

```diff
-	for _, urnOrAlias := range append([]resource.URN{urn}, goal.Aliases...) {
+	aliases[urn] = struct{}{}
+	for urnOrAlias := range aliases {
```

Previously, aliases were in a slice and we always looked for the URN
first, then aliases.

With , aliases changed to being stored in a map (a set). The URN
was added to the map before iterating over it, but there's no guarantee
it will be looked at first (iteration order for maps is unspecified),
and with the current behavior when there are aliases in the map, the URN
very likely won't come first.

This can lead to duplicate resources in the state (stack corruption)
when the wrong old resource is chosen.

The fix is to move back to always checking for old resources using the
URN first. We also move back to maintaining aliases in a slice for
consistent ordering.

Fixes 
2023-09-06 12:17:02 +00:00
Justin Van Patten 59dc4be453 Add aliases/python/retype_component_child test 2023-06-14 05:19:17 -07:00
Justin Van Patten 8db3e05fab Add aliases/python/rename_component_child test 2023-06-14 05:19:17 -07:00
Justin Van Patten 200feb43c9 Add aliases/python/extract_component_child test 2023-06-14 05:19:17 -07:00
Justin Van Patten 322e63e0a6 Add aliases/python/adopt_component_child test 2023-06-14 05:19:17 -07:00
Fraser Waters 3f3f4c92af
Fix python alias test () 2022-06-29 21:24:24 +01:00
Fraser Waters 84ef37a416
More alias tests ()
* Add more tests for aliases

* Mark the alias property as reserved
2022-06-29 19:50:26 +01:00
Matt Ellis 431413dcbb Add requirements.txt to all test projects
We don't actually depend on anything right now because all of these
tests just depend on `pulumi` which is installed as an editable
package.
2019-08-23 15:02:58 -07:00
CyrusNajmabadi 237f8d2222
Add python aliases support. () 2019-07-25 11:21:06 -07:00