Commit Graph

66 Commits

Author SHA1 Message Date
yeahyear cd1008562d
chore: remove repetitive words ()
<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. -->

Fixes # (issue)

## Checklist

- [ ] I have run `make tidy` to update any new dependencies
- [ ] I have run `make lint` to verify my code passes the lint check
  - [ ] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->

Signed-off-by: yetyear <flite@outlook.com>
2024-03-13 05:14:04 +00:00
Thomas Gummerer 4f65113a78
document active imperative mood for changelog messages ()
As we discussed in ideation yesterday, this is the way we want to go,
and try to be consistent with it. I've also opened
https://github.com/pulumi/go-change/pull/25 to update the go-change tool
to suggest that mood.

---------

Co-authored-by: Justin Van Patten <jvp@justinvp.com>
2024-03-02 06:02:26 +00:00
Julien P a713c05a6e
Add work target to initialize a go workspace ()
# Description

Add a make target to setup a go workspace. This is needed to make
`gopls`, the go language server, work seamlessly when opening the root
of the repo.
2024-01-05 13:16:30 +00:00
Joe Duffy 96a9a77167
Policy remediations feature ()
This PR implements the new policy transforms feature, which allows
policy packs to not only issue warnings and errors in response to policy
violations, but actually fix them by rewriting resource property state.
This can be used, for instance, to auto-tag resources, remove Internet
access on the fly, or apply encryption to storage, among other use
cases.
2023-10-09 18:31:17 +00:00
Justin Van Patten 2016359133
ci: Test with Go 1.20, 1.21 ()
Go 1.21 was recently released.
Switch to testing with Go 1.20 and 1.21.

Fixes 
2023-08-21 15:58:21 +00:00
Abhinav Gupta 6befaf3760
CONTRIBUTING: Clarify gofumpt further
We mention that you need to install gofumpt,
but it's easy to miss that there's some editor setup involved.

gofumpt is not mentioned in the `brew install` which,
depending on editor, may be necessary.
(Editors that use gopls don't need to install it globally,
but editors that invoke it manually need it installed.)

Lastly, Submitting a PR could do with explaining the lint/gofumpt
requirements.

Ref: https://github.com/pulumi/pulumi/pull/12854#discussion_r1190467688
2023-05-10 17:08:08 -07:00
Robbie McKinstry 5d938b7ebd
Update documentation to point to Node 16+ 2023-05-09 17:02:41 -04:00
Abhinav Gupta 9f01b3a4d4
CONTRIBUTING: Require a supported version of Go
Pulumi supports the same versions of Go as upstream.
Instead of updating the CONTRIBUTING.md with every Go releas,
specify that contributors should install "a supported version",
which will normally be one of the two most recent minor releases.

Resolves 
2023-04-12 14:43:26 -07:00
Abhinav Gupta 7aa5b77a0c
all: Reformat with gofumpt
Per team discussion, switching to gofumpt.

[gofumpt][1] is an alternative, stricter alternative to gofmt.
It addresses other stylistic concerns that gofmt doesn't yet cover.

  [1]: https://github.com/mvdan/gofumpt

See the full list of [Added rules][2], but it includes:

- Dropping empty lines around function bodies
- Dropping unnecessary variable grouping when there's only one variable
- Ensuring an empty line between multi-line functions
- simplification (`-s` in gofmt) is always enabled
- Ensuring multi-line function signatures end with
  `) {` on a separate line.

  [2]: https://github.com/mvdan/gofumpt#Added-rules

gofumpt is stricter, but there's no lock-in.
All gofumpt output is valid gofmt output,
so if we decide we don't like it, it's easy to switch back
without any code changes.

gofumpt support is built into the tooling we use for development
so this won't change development workflows.

- golangci-lint includes a gofumpt check (enabled in this PR)
- gopls, the LSP for Go, includes a gofumpt option
  (see [installation instrutions][3])

  [3]: https://github.com/mvdan/gofumpt#installation

This change was generated by running:

```bash
gofumpt -w $(rg --files -g '*.go' | rg -v testdata | rg -v compilation_error)
```

The following files were manually tweaked afterwards:

- pkg/cmd/pulumi/stack_change_secrets_provider.go:
  one of the lines overflowed and had comments in an inconvenient place
- pkg/cmd/pulumi/destroy.go:
  `var x T = y` where `T` wasn't necessary
- pkg/cmd/pulumi/policy_new.go:
  long line because of error message
- pkg/backend/snapshot_test.go:
  long line trying to assign three variables in the same assignment

I have included mention of gofumpt in the CONTRIBUTING.md.
2023-03-03 09:00:24 -08:00
fahaddd-git b68d10248b added links for go, node, and python downloads 2022-10-14 16:06:27 -04:00
Robbie McKinstry 385d08218a
Update contributor.md to describe new changelog process. 2022-09-20 17:17:46 -04:00
Kyle Pitzen 41b8bac555
chore: Adds note about integration test environment config () 2022-08-24 09:55:14 +01:00
Alma Eyre 8d32871857
Added s to fix typo () 2022-08-22 09:16:25 +01:00
Thomas Kappler 0e7ba17580
Add jq to required build tools and update Go version () 2022-08-09 14:52:44 -07:00
Robbie McKinstry acf2b2c194
Add description of one-feature-per-pr () 2022-07-26 12:50:10 -04:00
Mikhail Shilkov 75f1415abe
Update Contributing.md to point to the latest .NET () 2022-06-27 23:27:46 +02:00
Fraser Waters b96f69d6b6
Update CONTRIBUTING.md for employees () 2022-05-17 15:05:20 -07:00
Guinevere Saenger 7772c3e846
Update contributor guide ()
* Update contributor guide

* Apply suggestions from code review

Co-authored-by: Josh Kodroff <jkodroff@users.noreply.github.com>

* refer to correct Node version

* clean up final paragraph per @jkodroff's suggestion

Co-authored-by: Josh Kodroff <jkodroff@users.noreply.github.com>
2022-02-02 11:56:41 -08:00
Ian Wahbe 3f79185040
Move `PULUMI_ROOT` to `$HOME/.pulumi-dev` ()
* Move PULUMI_ROOT to relative path $REPO/.bin

* Add .bin to gitignore

* Change home to $HOME/.pulumi-dev

* Cleanup nodejs/readme and remove .bin (gitignore)
2021-12-15 12:32:41 -08:00
Justin Van Patten 096b667ee1
Replace the use of pipenv with Python's venv ()
We've had a few issues in the recent past related to pipenv oddities in
CI which lead us to temporarily globally install the Python SDK in CI.

This change removes the use of pipenv in favor of Python's built-in
venv and avoids globally installing the Python SDK.
2021-12-07 07:59:07 -08:00
Alex Mullans c39343fa3d
Update CONTRIBUTING.md with latest information ()
* Update CONTRIBUTING.md

* Add `make dist` to recommended make targets
2021-11-23 16:31:56 -08:00
Ian Wahbe b9f57bc6b9
Move `/opt/pulumi` to `$HOME/.pulumi` ()
* Move `/opt/pulumi` to `$HOME/.pulumi`

* Don't suggest adding $HOME/.pulumi to PATH
2021-11-17 10:37:38 -08:00
Fraser Waters 02ed28dd8c
Update go version in brew command line in CONTRIBUTING.md ()
The go version in the brew command line didn't match the version of go listed above in the list of requirements.
2021-10-20 09:30:39 +01:00
Fraser Waters b56d902afe
Add that pulumictl is needed to make pulumi () 2021-10-12 09:51:12 -07:00
Ian Wahbe 20287afdd7
Iwahbe/8000/uprgade go versions ()
* Upgrade the pulumi cli to go1.17.1

* Run go mod tidy

* Update CHANGELOG_PENDING.md

* Update pkg/go.mod for go1.17

* Update sdk and tests
2021-10-11 09:47:08 -07:00
T-Vova c0f0044a83
Update of CONTRIBUTING.md to reflect 3.0 changelog ()
CONTRIBUTING.md updated to require NodeJS v12.x rather than v10.x, as Pulumi 3.0 no longer supports the latter.
2021-08-03 17:16:07 -07:00
Jan Keromnes c8eac38286
Fully-automate development setup with Gitpod () 2021-03-10 08:13:35 -08:00
Paul Stack 20e84dfe9e
Upgrading Go to 1.16.x () 2021-03-09 20:05:23 +00:00
Mike Chen 256e8284d0
[automation] - Add diff to up and preview in automation API ()
Co-authored-by: Mike Chen <mikechen@ip-192-168-1-8.ec2.internal>
2021-02-23 17:38:28 -08:00
Paul Stack aab9cb5e42
Changing the process for CHANGELOG entries ()
As part of our continued effort to make our releases more useful,
we will be adding our CHANGELOG entries to the GitHub Release.

To make this process smooth, we are going to change things a little:

1. All new changelog entries when submitting a PR for an upcoming
release will now need to get added to CHANGELOG_PENDING.md
This is the source of information for what will be delivered in the
release.

2. When a release is being made, the entries from CHANGELOG_PENDING
will be copied to a new version and dated section in CHANGLOG to
mark the release

3. The GH tags will continue as normal and Goreleaser will copy
the changelog entries to the release section in GH
2021-02-23 19:59:59 +00:00
Eric Rudder fb78d1d9dd
go 1.13 to 1.15
as above
2020-11-30 10:41:03 -08:00
Lee Briggs 89c956d189
add pulumictl to dependencies () 2020-10-19 15:28:17 -07:00
sashu-shankar 231411019a
Update CONTRIBUTING.md 2020-06-23 15:52:43 -07:00
jkisk 661215b489 update ulimit () 2020-01-08 10:59:20 -08:00
Evan Boyle 8dbe6650e7
update setup instructions () 2019-11-19 15:45:23 -08:00
Evan Boyle 47662346d0
various fixes to get build running on mac () 2019-11-06 11:11:38 -08:00
evanboyle 9e7d8a6ed6 Fixing Istanbul usage 2019-11-05 11:17:07 -08:00
Evan Boyle 48a1d3c3cb Improve contributing setup docs () 2019-11-05 07:39:51 -08:00
Luke Hoban ba081086a8
Update CONTRIBUTING.md 2019-10-29 14:48:41 -07:00
Luke Hoban 3f738ab496
Update CONTRIBUTING.md 2019-10-29 14:48:11 -07:00
Matt Ellis 32ac67e6bc Remove the need for `pandoc` during the build
We had been using `pandoc` to convert our README.md into a README.rst
for use with `setup.py` and the python package ecosystem. It turns out
that we can use markdown if we set a content type. So let's do that
and make things a little simpler.

While I was in the area, I made the encoding of UTF-8 explicit when
opening README.md.
2019-09-09 11:15:42 -07:00
James Nugent 7f6a6501ef Depend on `pulumi` fork of `glog`.
This removes the need for a replace directive in every downstream `go.mod`.
2019-07-25 16:10:53 -05:00
Chris Smith 208dfc29b4
Update references to pulumi.io ()
* Remove pulumi.io reference in tests

* Remove pulumi.io references in Dockerfiles

* Remove pulumi.io references in CONTRIBUTING.md

* Update README.md's

* Use correct logo
2019-07-25 09:58:12 -07:00
david raistrick 2e08a9c5d2 add golangci-lint to brew install in contributing 2019-06-18 14:44:41 -07:00
david raistrick 4833fe1045 add go to brew install for contributing 2019-06-18 11:08:53 -07:00
Kraig Amador 23a52ec0bb
Documentation update to include a step missing that helps new users build Pulumi 2019-05-02 10:18:02 -07:00
Levi Blackstone b3da211b71
Update required Go version to 1.12+ 2019-04-26 10:13:13 -06:00
James Nugent edab10e9c8 Use Go Modules for dependency tracking
This commit switches from dep to Go 1.12 modules for tracking Pulumi
dependencies. Rather than _building_ using Go modules, we instead use the `go
mod vendor` command to populate a vendor tree in the same way as `dep ensure`
was previously doing.

In order to prevent checksum mismatches, it was necessary to also update CI to
use Go 1.12 instead of 1.11 - which also necessitated fixing some linting errors
which appeared with the upgraded golangci-lint for 1.12.
2019-04-10 08:37:51 +04:00
Matt Ellis aa7f26a3b5 Have README.md point at CONTRIBUTING.md
Instead of duplicating information about how to build Pulumi from
source in both `README.md` and `CONTRIBUTING.md`, just have the
`README.md` point at `CONTRIBUTING.md`.

Fixes 
2018-11-13 11:50:12 -08:00
Matt Ellis 992b048dbf Adopt golangci-lint and address issues
We run the same suite of changes that we did on gometalinter. This
ended up catching a few new issues, some of which were addressed and
some of which were baselined.
2018-11-08 14:11:47 -08:00