pulumi/sdk/go/common/util
Fraser Waters 571fadae3f Use slice.Prealloc instead of make([]T, 0, ...)
Fixes https://github.com/pulumi/pulumi/issues/12738

https://github.com/pulumi/pulumi/pull/11834 turned on the prealloc
linter and changed a load of slice uses from just `var x T[]` to `x :=
make([]T, 0, preallocSize)`. This was good for performance but it turns
out there are a number of places in the codebase that treat a `nil`
slice as semnatically different to an empty slice.

Trying to test that, or even reason that through for every callsite is
untractable, so this PR replaces all expressions of the form `make([]T,
0, size)` with a call to `slice.Prealloc[T](size)`. When size is 0 that
returns a nil array, rather than an empty array.
2023-06-29 11:27:50 +01:00
..
archive sdk/go/common/util cleanup 2023-03-10 08:49:00 +00:00
buildutil sdk/go/common/util cleanup 2023-03-10 08:49:00 +00:00
ciutil chore: Update doc comments, coding style, fix lint 2022-10-13 13:50:49 -07:00
cmdutil Use slice.Prealloc instead of make([]T, 0, ...) 2023-06-29 11:27:50 +01:00
contract sdk/contract: Deprecate non-f variants 2023-03-03 14:37:59 -08:00
deepcopy all: Fix revive issues 2023-03-21 08:55:11 -07:00
env gosimple: printf, time.Since, TrimPrefix, etc. 2023-01-12 09:55:34 -08:00
executable sdk/go/common/util cleanup 2023-03-10 08:49:00 +00:00
fsutil Make convert more lenient 2023-06-08 11:14:31 +01:00
gitutil sdk/go/common/util cleanup 2023-03-10 08:49:00 +00:00
goversion sdk/go/common/util cleanup 2023-03-10 08:49:00 +00:00
httputil all: Reformat with gofumpt 2023-03-03 09:00:24 -08:00
logging Use slice.Prealloc instead of make([]T, 0, ...) 2023-06-29 11:27:50 +01:00
mapper sdk/go/common/util cleanup 2023-03-10 08:49:00 +00:00
result sdk/go/common/util cleanup 2023-03-10 08:49:00 +00:00
retry sdk/common/retry: Fix extraneous backoff 2023-03-24 16:39:02 -07:00
rpcutil all: Reformat with gofumpt 2023-03-03 09:00:24 -08:00
yamlutil all: Reformat with gofumpt 2023-03-03 09:00:24 -08:00