mirror of https://github.com/pulumi/pulumi.git
af1cbee4fb
13298: ci: Track code coverage r=abhinav a=abhinav **Overview** This re-enables tracking of code coverage. For Go, there are two kinds of coverage at play: unit test and integration test coverage. Unit tests follow the usual pattern of running `go test -cover -coverprofile=whatever.cov`. For integration tests, we use the new integration test profiling support [added in Go 1.20](https://go.dev/testing/coverage/). In short, the way it works is: # Build a coverage instrumented binary: go build -cover # Set GOCOVERDIR to a directory and run the integration tests # that will invoke this coverage-instrumented binary. GOCOVERDIR=$(pwd)/coverage go test ./tests # $GOCOVERDIR will now be filled with coverage data # from every invocation of the coverage-instrumented binary. # Combine it into a single coverage file: go tool covdata textfmt -i=$(GOCOVERDIR) -o=out.cov # The resulting file can be uploaded to codecov as-is. The above replaces the prior, partially working hacks we had in place to get coverage-instrumented binaries with `go test -c` and hijacking the TestMain. **Notable changes** - TestMain hijacking is deleted from the Pulumi CLI. We no longer need this to build coverage-instrumented binaries. - ProgramTest no longer tracks or passes PULUMI_TEST_COVERAGE_PATH because the Pulumi binary no longer accepts a test.coverprofile flag. This information is now in the GOCOVERDIR environment variable. - We add an `enable-coverage` parameter to the `ci-build-binaries` workflow to mirror some of the other workflows. It will produce coverage-instrumented binaries if this is true. These binaries are then used by `ci-run-test` which will set `GOCOVERDIR` and merge the coverage results from it. - Coverage configuration no longer counts tests, testdata, and Protobuf-generated code against coverage. - go-wrapper.sh: Because we're no longer relying on the `go test -c` hack, this no longer excludes Windows and language providers from coverage tracking. - go-test.py and go-wrapper.sh will include pulumi-language-go and pulumi-language-nodejs in covered packages. *Other changes* - go-test.py: Fixed a bug where `args` parameters added for coverage were ignored. Note that this change DOES NOT track coverage for calls made to Pulumi packages by plugins downloaded from external sources, e.g. provider plugins. Arguably, that's out of scope of coverage trackcing for the Pulumi repository. Resolves #8615, #11419 Co-authored-by: Abhinav Gupta <abhinav@pulumi.com> |
||
|---|---|---|
| .. | ||
| 20230601--cli-state--the-upgrade-command-now-prompts-the-user.yaml | ||
| 20230609--engine--old-inputs-are-sent-to-provider-diff-functions-as-well-as-the-old-outputs.yaml | ||
| 20230620--programgen-go--fix-aliasing-package-names-using-dashes-when-schema-doesnt-include-go-package-info-override.yaml | ||
| 20230622--cli--stack-output-on-the-console-no-longer-escapes-html-characters-inside-json-strings.yaml | ||
| 20230622--cli-state--disallow-renaming-resources-to-invalid-names-that-will-corrupt-the-state.yaml | ||
| 20230622--programgen-go--use-raw-string-literals-for-long-multi-line-strings.yaml | ||
| 20230622--programgen-nodejs-python--prefer-output-versioned-invokes-in-generated-programs-for-nodejs-and-python.yaml | ||
| 20230622--sdk-go-nodejs-python--missing-config-error-text-includes-secret-if-requiresecret-was-used.yaml | ||
| 20230622--sdk-nodejs--update-atgrpc-grpc-js-to-1-8-16.yaml | ||
| 20230623--cli-display--print-the-summary-event-for-previews-that-contain-non-error-level-diagnostic-messages.yaml | ||
| 20230623--engine--engine-marks-outputs-secret-if-an-output-of-the-same-name-is-marked-secret.yaml | ||
| 20230624--auto-nodejs--adds-a-better-error-message-for-invalid-nodejs-autoapi-workdir.yaml | ||
| 20230624--sdk-nodejs--support-loading-package-json-from-parent-directory.yaml | ||
| 20230626--cli--improve-the-cli-stack-validation-error-message.yaml | ||
| 20230626--cli-package--fixes-resolving-plugins-when-they-are-not-yet-installed-in-plugin-cache.yaml | ||
| 20230628--cli-display--fix-diffs-sometimes-not-showing-even-in-details-view.yaml | ||
| 20230628--cli-state--add-interactive-urn-selection-to-pulumi-state-rename-unprotect-delete.yaml | ||
| 20230628--pkg-testing--programtest-dropped-the-coverprofile-option-as-its-no-longer-necessary.yaml | ||
| 20230628--sdkgen--fix-loading-schemas-from-providers-on-path.yaml | ||