pulumi/pkg/codegen/schema
Abhinav Gupta d8c8c74c5d
golangci-lint: Enable staticcheck
Remove staticcheck from the list of disabled linters.
It's enabled by default in golangci-lint.

This also fixes minor remaining staticcheck issues
that don't merit their own pull requests,
or opts out of those that cannot be fixed yet.

Notably, we're opting out of:

- Resource.Name is deprecated (#9469)
- github.com/golang/protobuf is deprecated (#11869)
- strings.Title has been deprecated (#11870)

Besides that, other issues addressed in this change are:

```
// all issues are in pkg
codegen/schema/docs_parser.go:103:4: SA4006: this value of `text` is never used (staticcheck)
codegen/schema/loader.go:253:3: SA9003: empty branch (staticcheck)
resource/deploy/step_executor.go:328:12: SA9003: empty branch (staticcheck)
resource/deploy/step_generator.go:141:10: SA9003: empty branch (staticcheck)
codegen/pcl/invoke.go:97:10: SA9003: empty branch (staticcheck)
codegen/hcl2/model/type_const.go:57:2: SA9003: empty branch (staticcheck)
codegen/hcl2/model/type_enum.go:99:9: SA4001: &*x will be simplified to x. It will not copy x. (staticcheck)
codegen/go/gen_test.go:399:19: SA4017: HasPrefix is a pure function but its return value is ignored (staticcheck)
```

Depends on #11857, #11858, #11859, #11860, #11862, #11865, #11866, #11867, #11868

Resolves #11808
2023-01-14 16:59:46 -08:00
..
bind.go Merge #11819 #11834 #11842 #11845 2023-01-12 20:11:42 +00:00
docs_parser.go golangci-lint: Enable staticcheck 2023-01-14 16:59:46 -08:00
docs_renderer.go [breaking] Changing the version of go.mod in sdk / pkg to be v3 2021-04-14 19:32:18 +01:00
docs_test.go Initial implementation of simplified invokes for dotnet and nodejs 2023-01-11 14:17:14 -08:00
loader.go golangci-lint: Enable staticcheck 2023-01-14 16:59:46 -08:00
loader_schema_test.go perf: Use a faster check for empty schemas (#10444) 2022-08-19 07:40:59 -07:00
loader_test.go [schema] Faster schema loading via caching alongside plugins (#9686) 2022-06-13 23:27:11 -07:00
mock_pulumi_schema.go Test YAML PCL examples 2022-10-24 10:33:48 -07:00
package_reference.go Add description to PackageReference (#9800) 2022-06-08 12:53:13 -07:00
pulumi.json Initial implementation of simplified invokes for dotnet and nodejs 2023-01-11 14:17:14 -08:00
schema.go Merge #11819 #11834 #11842 #11845 2023-01-12 20:11:42 +00:00
schema_test.go Initial implementation of simplified invokes for dotnet and nodejs 2023-01-11 14:17:14 -08:00