pulumi/changelog/pending
Thomas Kappler 967f92b566
Don't swallow file not found in fsutil.FileCopy (#14695)
# Description

`FileCopy` silently swallows file not found errors which leads to hard
to debug issues. For instance, as described in #14694, tests with edit
steps unexpectedly run twice against the first step.

Fixes #14694
Fixes #5230 

Merging this will break plenty of existing tests if they're not fixed
first. [This
query](https://github.com/search?q=org%3Apulumi+path%3A_test.go+%2F%5E%5Ct*Dir%3A+*%22%2F&type=code)
is a rough indication.

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->

---------

Co-authored-by: Fraser Waters <fraser@pulumi.com>
2023-12-06 13:29:40 +00:00
..
20230926--backend-service--service-backend-now-validates-snapshots-are-valid-on-load-same-as-the-self-managed-backend.yaml Validate snapshots from service on load (#14046) 2023-12-04 15:12:56 +00:00
20231026--sdk-nodejs--add-typescript-definitions-for-the-grpc-and-protobuf-generated-code.yaml Update node sdk to use typescript definitions for grpc and protobufs. (#14415) 2023-12-04 15:22:44 +00:00
20231116--cli--add-import-file-to-pulumi-preview-to-generate-a-placeholder-import-file-for-every-resource-that-needs-to-create.yaml Add --import-file to pulumi preview (#14548) 2023-12-05 08:32:40 +00:00
20231127--sdkgen--return-all-bind-diagnostics-in-sdk-gen-rather-than-just-the-first.yaml Return diagnostics from GeneratePackage (#14661) 2023-12-05 17:47:52 +00:00
20231128--engine--error-if-a-resources-parent-is-a-skipped-create.yaml Error if a resource's parent is a skipped create (#14672) 2023-12-02 22:37:12 +00:00
20231128--engine--warn-if-sdks-are-trying-to-use-old-registerresource-style-stackreferences.yaml Warn if StackReferences are registered instead of read (#14678) 2023-12-03 08:46:37 +00:00
20231129--engine--send-resource-inputs-as-inputs-and-state-for-reads.yaml Pass inputs to read as inputs and state (#14683) 2023-12-02 14:39:38 +00:00
20231130--engine--engine-now-prefers-stable-plugin-versions-to-pre-releases-when-no-explict-version-is-given.yaml Prefer stable plugin release to pre-releases (#14700) 2023-12-03 09:15:07 +00:00
20231130--sdkgen-go--fix-compiling-plain-element-type-with-plain-maps.yaml [sdk-gen/go] Fix compiling plain element type with plain maps (#14704) 2023-12-04 12:34:40 +00:00
20231201--auto-python--ensures-that-the-project_settings-has-a-main-directory-for-inline-programs-in-python.yaml Sets the `main` project setting to the cwd for inline programs (#14709) 2023-12-01 23:05:08 +00:00
20231201--cli-display--fix-a-panic-in-diff-display-when-parsing-yaml-strings.yaml Fix a panic in diff display when parsing YAML strings (#14710) 2023-12-02 01:24:13 +00:00
20231204--engine--fix-handling-of-delete-failures-for-targeted-destroys.yaml Fix handling of delete failures for targeted destroys (#14735) 2023-12-05 17:19:10 +00:00
20231204--sdkgen-go--fix-generating-input-collection-types-for-enums-when-used-from-an-array-of-map-of-enums.yaml [sdk-gen/go] Fix generating input collection types when used from an array of map of enums (#14744) 2023-12-05 12:29:30 +00:00
20231205--auto--dont-swallow-error-if-editdir-is-not-found-in-programtest.yaml Don't swallow file not found in fsutil.FileCopy (#14695) 2023-12-06 13:29:40 +00:00