pulumi/sdk/go/common
Thomas Kappler 967f92b566
Don't swallow file not found in fsutil.FileCopy (#14695)
# Description

`FileCopy` silently swallows file not found errors which leads to hard
to debug issues. For instance, as described in #14694, tests with edit
steps unexpectedly run twice against the first step.

Fixes #14694
Fixes #5230 

Merging this will break plenty of existing tests if they're not fixed
first. [This
query](https://github.com/search?q=org%3Apulumi+path%3A_test.go+%2F%5E%5Ct*Dir%3A+*%22%2F&type=code)
is a rough indication.

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->

---------

Co-authored-by: Fraser Waters <fraser@pulumi.com>
2023-12-06 13:29:40 +00:00
..
apitype [cli] Include config from ESC in `pulumi config` (#14560) 2023-11-21 10:44:45 +00:00
channel Send all events to the engine event stream (#14607) 2023-11-20 21:55:59 +00:00
constant Send update metadata about update plans 2022-10-12 22:55:59 +01:00
diag [sdk] Update uniseg 2023-05-25 22:24:13 -07:00
encoding all: Reformat with gofumpt 2023-03-03 09:00:24 -08:00
env [sdk/python] Adds a default exception when dependency cycles are created (#14597) 2023-11-21 16:26:02 +00:00
promise Use promise rather than `atomic.Value` to record step errors. (#14612) 2023-11-18 19:03:35 +00:00
resource Return diagnostics from GeneratePackage (#14661) 2023-12-05 17:47:52 +00:00
slice Use slice.Prealloc instead of make([]T, 0, ...) 2023-06-29 11:27:50 +01:00
testing Start policy packs in parallel (#14495) 2023-11-20 14:08:32 +00:00
tokens Add tokens.StackName (#14487) 2023-11-15 07:44:54 +00:00
tools all: Reformat with gofumpt 2023-03-03 09:00:24 -08:00
util Don't swallow file not found in fsutil.FileCopy (#14695) 2023-12-06 13:29:40 +00:00
version move pkg/version -> sdk/go/common/version 2020-03-18 15:25:25 -07:00
workspace Prefer stable plugin release to pre-releases (#14700) 2023-12-03 09:15:07 +00:00