mirror of https://github.com/pulumi/pulumi.git
ec469864ee
13021: Use os.tmpfile instead of creating our own. r=RobbieMcKinstry a=RobbieMcKinstry <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> This PR uses os.Tempfile instead of creating our own with UUID. The standard library's os.Tempfile function is race-safe, collision-proof, and uses the OS's tempdir, which allows the OS to clean up old files if Pulumi were to fail to do so. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 13054: ci(lint): Helpful message on tidy failure r=abhinav a=abhinav When the 'go mod tidy' lint check fails, it prints a simple error message reporting the failure. Most will resort to running `go mod tidy` manually to attempt to fix this, but this will not always work. We need to run `./scripts/tidy.sh` which updates all go.mod files and includes specific compatibility flags. Co-authored-by: Robbie McKinstry <robbie@pulumi.com> Co-authored-by: Abhinav Gupta <abhinav@pulumi.com> |
||
|---|---|---|
| .. | ||
| manager.go | ||
| manager_test.go | ||
| npm.go | ||
| npm_test.go | ||
| yarn.go | ||