mirror of https://github.com/pulumi/pulumi.git
a0ea0df5a2
11881: Add optional / backwards compatible generic types to dynamic.ResourceProvider r=Frassle a=Asamsig <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #11875 Added generic type definitions to `pulumi.dynamic.ResourceProvider` making it easier and safer to write dynamic providers in TypeScript. This change is backwards compatible, since the generic types will default to `any`, and you'd have to opt-in to get type safety by supplying an `Inputs` and `Outputs` type definition to the now generic `ResourceProvider`-interface. This will make it much easier to write a dynamic provider by being able to leverage the types. I think in 4.0 you should consider changing the default from `any` to `unknown`, forcing users to supply types for Inputs and Outputs. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 11950: Add test and fix for symlinks in node_modules r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> I think this should help with https://github.com/pulumi/pulumi/issues/11946. I'm a little confused, how the problem repo in #11946 isn't hanging forever because my test of a recursive symlink does. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Service, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Alexander Samsig <koresamsig@gmail.com> Co-authored-by: Fraser Waters <fraser@pulumi.com> |
||
|---|---|---|
| .. | ||
| index.ts | ||