mirror of https://github.com/pulumi/pulumi.git
a3e724e08b
13172: [pcl/binder] Extend SkipResourceTypechecking to allow binding and generating unknown resources r=Zaid-Ajaj a=Zaid-Ajaj # Description Currently when generating code from PCL and we have unknown resources (those without a schema), the binder fails and the conversion stops. This is not ideal when we try to convert terraform codebases that include resources which we haven't bridged yet. This PR addresses this issue by extending `pcl.SkipResourceTypechecking` to _allow_ binding unknown resources and making a best guess in program-gen of how those will look even when we their schema is `nil`. The option `pcl.SkipResourceTypechecking` is already enabled for `pulumi convert` and it can be disabled when running in _strict_ mode `pulumi convert --strict` A similar feature is still be needed for unknown _invokes_ but that can be tackled in a separate PR ## Checklist - [ ] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Zaid Ajaj <zaid.naom@gmail.com> |
||
|---|---|---|
| .. | ||
| pending | ||
| config.yaml | ||