pulumi/pkg/backend/display
bors[bot] 8915911825
Merge #11819 #11834 #11842 #11845
11819: Cleanup diag error for protected resources r=dixler a=iwahbe

Change the error message for deleting protected resources so it sounds less like we tried and failed to delete the resource, and more like we chose not to. 

Fixes #11816


11834: Preallocate slices with a known capacity. r=dixler a=RobbieMcKinstry

Enable the prealloc linter, which identifies slices with a known capacity, but are not preallocated, which results in unnecessary allocations and memcpys.

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] N/A: enabling a linter. I have added tests that prove my fix is effective or that my feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] **N/A: not a user-facing change.** I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


11842: Changelog and go.mod updates for v3.51.1 r=dixler a=justinvp



11845: Move SecretsProvider to pkg/secrets r=dixler a=Frassle

<!--- 
Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. -->

Trying to push DefaultSecretsProvider up past the backends resulted in a module loop between pkg/resource/stack and pkg/resource/deploy. This places SecretProvider in the secrets module to avoid that.

## Checklist

<!--- Please provide details if the checkbox below is to be left unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my feature works - N/A Just moving interface declaration 
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change - N/A Internal code changes
<!--
If the change(s) in this PR is a modification of an existing call to the Pulumi Service,
then the service should honor older versions of the CLI where this change would not exist.
You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Service API version - No
  <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. -->


Co-authored-by: Ian Wahbe <ian@wahbe.com>
Co-authored-by: Robbie McKinstry <robbie@pulumi.com>
Co-authored-by: Abhinav Gupta <abhinav@pulumi.com>
Co-authored-by: Robbie McKinstry <thesnowmancometh@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Fraser Waters <fraser@pulumi.com>
2023-01-12 20:11:42 +00:00
..
internal/terminal [display] Hide the cursor in interactive mode. 2022-12-20 10:56:59 -08:00
testdata Update test baselines 2022-12-20 10:27:31 -08:00
diff.go Repair tests expecting nil slices 2023-01-11 21:53:04 -08:00
diff_test.go backend/display/test: string(buffer.Bytes()) => buffer.String() 2023-01-10 11:52:08 -08:00
display.go [cli] Add a replay-events debug command. (#9271) 2022-04-07 09:03:19 -07:00
doc.go Document Go packages (#6009) 2021-01-11 11:07:59 -07:00
events.go getDiffInfo: Fix slice length check 2023-01-11 21:53:05 -08:00
json.go Add DeletedWith resource option 2022-10-31 12:03:18 +02:00
jsonmessage.go unused: Remove unused functions and types 2023-01-12 09:55:34 -08:00
object_diff.go Repair tests expecting nil slices 2023-01-11 21:53:04 -08:00
options.go [cli] Abstract out terminal interactions 2022-11-08 17:13:56 -08:00
progress.go gosimple: printf, time.Since, TrimPrefix, etc. 2023-01-12 09:55:34 -08:00
progress_test.go backend/display/test: string(buffer.Bytes()) => buffer.String() 2023-01-10 11:52:08 -08:00
query.go re-enable and color dot spinner for non-interactive mode (#8996) 2022-02-15 14:37:04 -08:00
rows.go getDiffInfo: Fix slice length check 2023-01-11 21:53:05 -08:00
sigint_unix.go [cli] Reimplement the interactive renderer 2022-11-07 22:02:44 -08:00
sigint_windows.go [cli] Reimplement the interactive renderer 2022-11-07 22:02:44 -08:00
tableutil.go [color] Use graphemes to measure strings. 2022-11-09 08:23:00 -08:00
tree.go sdk/go: Remove 'nolint' directives from package docs 2023-01-06 09:06:47 -08:00
watch.go [cli] Add a replay-events debug command. (#9271) 2022-04-07 09:03:19 -07:00