mirror of https://github.com/pulumi/pulumi.git
656cf29179
13251: [convert] Prefer output-versioned invokes in generated programs for nodejs and python r=Zaid-Ajaj a=Zaid-Ajaj ### Description This PR implements a new PCL bind option called `PreferOutputVersionedInvokes` which as the name suggests gives higher priority to using output-versioned invokes in generated programs if they exist* but only for python and nodejs. Previously we have enabled this for all languages but it breaks go and dotnet programs so here it is only applied to python and typescript. Binding component programs carry over this option if the main program has it too. This work is a continuation of #13051 <details> <summary>PCL program example</summary> ``` vpc = invoke("aws:ec2:getVpc", { default = true }) subnets = invoke("aws:ec2:getSubnetIds", { vpcId = vpc.id }) resource webSecurityGroup "aws:ec2:SecurityGroup" { vpcId = vpc.id egress = [{ protocol = "-1" fromPort = 0 toPort = 0 cidrBlocks = ["0.0.0.0/0"] }] ingress = [{ protocol = "tcp" fromPort = 80 toPort = 80 cidrBlocks = ["0.0.0.0/0"] }] } ``` </details> <details> <summary>Generated TypeScript Before</summary> ```typescript const vpc = aws.ec2.getVpc({ "default": true, }); const subnets = vpc.then(vpc => aws.ec2.getSubnetIds({ vpcId: vpc.id, })); const webSecurityGroup = new aws.ec2.SecurityGroup("webSecurityGroup", { vpcId: vpc.then(vpc => vpc.id), egress: [{ protocol: "-1", fromPort: 0, toPort: 0, cidrBlocks: ["0.0.0.0/0"], }], ingress: [{ protocol: "tcp", fromPort: 80, toPort: 80, cidrBlocks: ["0.0.0.0/0"], }], }); ``` </details> <details> <summary>Generated TypeScript After</summary> ```typescript const vpc = aws.ec2.getVpcOutput({ "default": true, }); const subnets = aws.ec2.getSubnetIdsOutput({ vpcId: vpc.id, }); const webSecurityGroup = new aws.ec2.SecurityGroup("webSecurityGroup", { vpcId: vpc.id, egress: [{ protocol: "-1", fromPort: 0, toPort: 0, cidrBlocks: ["0.0.0.0/0"], }], ingress: [{ protocol: "tcp", fromPort: 80, toPort: 80, cidrBlocks: ["0.0.0.0/0"], }], }); ``` </details> > * The existence of output-versioned invokes depends on whether they have any arguments. The idea is to change that later such that every function invoke emits an output-versioned invoke regardless of whether it has input args or not. ## Checklist - [ ] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Zaid Ajaj <zaid.naom@gmail.com> |
||
|---|---|---|
| .. | ||
| 20230601--cli-state--the-upgrade-command-now-prompts-the-user.yaml | ||
| 20230609--engine--old-inputs-are-sent-to-provider-diff-functions-as-well-as-the-old-outputs.yaml | ||
| 20230620--programgen-go--fix-aliasing-package-names-using-dashes-when-schema-doesnt-include-go-package-info-override.yaml | ||
| 20230622--cli--stack-output-on-the-console-no-longer-escapes-html-characters-inside-json-strings.yaml | ||
| 20230622--cli-state--disallow-renaming-resources-to-invalid-names-that-will-corrupt-the-state.yaml | ||
| 20230622--programgen-go--use-raw-string-literals-for-long-multi-line-strings.yaml | ||
| 20230622--programgen-nodejs-python--prefer-output-versioned-invokes-in-generated-programs-for-nodejs-and-python.yaml | ||
| 20230622--sdk-go-nodejs-python--missing-config-error-text-includes-secret-if-requiresecret-was-used.yaml | ||
| 20230622--sdk-nodejs--update-atgrpc-grpc-js-to-1-8-16.yaml | ||
| 20230623--cli-display--print-the-summary-event-for-previews-that-contain-non-error-level-diagnostic-messages.yaml | ||
| 20230623--engine--engine-marks-outputs-secret-if-an-output-of-the-same-name-is-marked-secret.yaml | ||
| 20230624--auto-nodejs--adds-a-better-error-message-for-invalid-nodejs-autoapi-workdir.yaml | ||