pulumi/pkg/resource/deploy
Fraser Waters 2b44cf6ec1
Fix duplicate resource error from failed delete operations (#14042)
<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. -->

Fixes https://github.com/pulumi/pulumi/issues/14041.

Fixes a URN normalisation error from respecting aliases from old
deployments.
We no longer write out aliases to snapshot files, so will no longer pick
these
aliases up on later deployments.

Longer term it would be good to refactor state and snapshot code so that
Aliases isn't on state at all, but side-channeled to snapshot code some
other
way. But this is a quick fix that starts the process of removing aliases
from
state now with minimal blast radius.

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [ ] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2023-09-26 15:18:35 +00:00
..
deploytest More efficent mapping lookup (#13975) 2023-09-21 11:45:07 +00:00
providers More efficent mapping lookup (#13975) 2023-09-21 11:45:07 +00:00
builtins.go More efficent mapping lookup (#13975) 2023-09-21 11:45:07 +00:00
deployment.go Pass provider checksums in requests and save to state (#13789) 2023-09-11 15:54:07 +00:00
deployment_executor.go Replace use of result.Result in step generator (#14028) 2023-09-25 12:25:23 +00:00
deployment_executor_test.go Use slice.Prealloc instead of make([]T, 0, ...) 2023-06-29 11:27:50 +01:00
deployment_test.go Remove source_fixed 2022-11-08 15:55:45 +00:00
doc.go Document Go packages (#6009) 2021-01-11 11:07:59 -07:00
import.go Pass provider checksums in requests and save to state (#13789) 2023-09-11 15:54:07 +00:00
manifest.go Split Manifest type to it's own file (#8712) 2022-01-10 12:25:24 +00:00
plan.go Move sdk/go/common/display to /pkg/display (#13954) 2023-09-18 11:01:28 +00:00
snapshot.go Fix duplicate resource error from failed delete operations (#14042) 2023-09-26 15:18:35 +00:00
snapshot_test.go all: Fix revive issues 2023-03-21 08:55:11 -07:00
source.go Change Source.Iterate to return an error (#13996) 2023-09-20 14:34:24 +00:00
source_error.go Change Source.Iterate to return an error (#13996) 2023-09-20 14:34:24 +00:00
source_eval.go Change Source.Iterate to return an error (#13996) 2023-09-20 14:34:24 +00:00
source_eval_test.go Add ConstructInfo to deploytest 2023-07-25 09:03:48 +01:00
source_null.go Change Source.Iterate to return an error (#13996) 2023-09-20 14:34:24 +00:00
source_query.go Replace result.Result in Query with error (#13939) 2023-09-20 15:43:46 +00:00
source_query_test.go Use context.Background in tests (#14029) 2023-09-25 12:25:26 +00:00
state_builder.go Fix duplicate resource error from failed delete operations (#14042) 2023-09-26 15:18:35 +00:00
state_builder_test.go When changing parents also fix URNs (#13935) 2023-09-14 19:52:27 +00:00
step.go Don't edit state in completion functions (#14038) 2023-09-25 18:22:23 +00:00
step_executor.go Update ExecuteRegisterResourceOutputs to use error (#13915) 2023-09-11 12:35:48 +00:00
step_generator.go Replace use of result.Result in step generator (#14028) 2023-09-25 12:25:23 +00:00
step_generator_test.go [engine] Check for old resources first by URN and then aliases (#13883) 2023-09-06 12:17:02 +00:00
target.go Add getOrganization to nodejs and python (#10504) 2022-08-31 10:33:29 +01:00