pulumi/sdk/go/common/resource
Zaid Ajaj a44a536f3b
[sdk/go] Ensure Assets of AssetArchive are non-nil when creating and deserializing (#14007)
Fixes #11103

The problem in the issue the distinction between `Assets` or an archive
being `nil` vs. being an empty map of assets. When creating and
deserializing Archives, `nil` was allowed which leads to panics when
asserting `archive.IsAssets()` because the `Assets` is `nil` even though
it is a proper archive.

This PR fixes the issue by ensuring that an instance of `Archive` will
have a non-nil `Assets` field whether that is during construction or
marshalling.

## Checklist

- [ ] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2023-09-22 15:46:19 +00:00
..
config all: Drop //nolint:goconst 2023-03-09 11:15:21 -08:00
plugin More efficent mapping lookup (#13975) 2023-09-21 11:45:07 +00:00
testing deps: Upgrade to pgregory.net/rapid v0.5 2023-02-16 12:04:07 -08:00
alias.go [engine] Fix aliasing children 2023-06-14 05:19:17 -07:00
alias_test.go feat(engine): Adds structured alias support to the engine 2022-10-11 17:56:32 -04:00
asset.go [sdk/go] Ensure Assets of AssetArchive are non-nil when creating and deserializing (#14007) 2023-09-22 15:46:19 +00:00
asset_test.go [sdk/go] Ensure Assets of AssetArchive are non-nil when creating and deserializing (#14007) 2023-09-22 15:46:19 +00:00
custom_timeouts.go move pkg/resource -> sdk/go/common/resource, but leave nested resource packages 2020-03-18 13:36:19 -07:00
errors.go [breaking] Changing the version of go.mod in sdk / pkg to be v3 2021-04-14 19:32:18 +01:00
mapper_test.go Allow decoding *asset and *archive values 2022-10-17 13:28:13 -07:00
properties.go Use slice.Prealloc instead of make([]T, 0, ...) 2023-06-29 11:27:50 +01:00
properties_diff.go Use slice.Prealloc instead of make([]T, 0, ...) 2023-06-29 11:27:50 +01:00
properties_diff_test.go all: Reformat with gofumpt 2023-03-03 09:00:24 -08:00
properties_path.go Fix wildcards and indexers in IgnoreChanges 2023-06-20 09:45:02 +01:00
properties_path_test.go Fix wildcards and indexers in IgnoreChanges 2023-06-20 09:45:02 +01:00
properties_test.go ci: radical idea - what if slow tests & no stdout makes GH consider runner dead? 2022-03-06 14:52:13 -08:00
resource_goal.go [engine] Add support for source positions 2023-07-10 14:35:40 -07:00
resource_id.go sdk/go: Prefer contract.Assertf over Assert 2023-02-15 10:22:43 -08:00
resource_id_test.go all: Drop //nolint:goconst 2023-03-09 11:15:21 -08:00
resource_operation.go move pkg/resource -> sdk/go/common/resource, but leave nested resource packages 2020-03-18 13:36:19 -07:00
resource_state.go [engine] Add support for source positions 2023-07-10 14:35:40 -07:00
stack.go [breaking] Changing the version of go.mod in sdk / pkg to be v3 2021-04-14 19:32:18 +01:00
status.go move pkg/resource -> sdk/go/common/resource, but leave nested resource packages 2020-03-18 13:36:19 -07:00
urn.go When changing parents also fix URNs (#13935) 2023-09-14 19:52:27 +00:00
urn_test.go ci: radical idea - what if slow tests & no stdout makes GH consider runner dead? 2022-03-06 14:52:13 -08:00