pulumi/pkg/util
Zaid Ajaj 2766475bd1
[cli/plugin] Fix plugin install command when plugin type is tool (#16407)
# Description

When trying to install a plugin of type `tool` from GitHub, the Pulumi
convention is to have these plugins available in repositories named
`pulumi-tool-<name>` so that we can install them via the CLI as follows:
```
pulumi plugin install tool <name>
```
However, today this fails because we don't prefix the repository name
correctly with `"pulumi-tool-"`. This PR fixes that. Tested against
[Zaid-Ajaj/pulumi-tool-importer](https://github.com/Zaid-Ajaj/pulumi-tool-importer)

Also removes hardcoded plugin download URL for known converter plugins
of mine. These are moved to the `pulumi` organisation and no longer
require a separate URL.

## Checklist

- [ ] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [ ] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2024-06-17 13:25:57 +00:00
..
afero Fix convert pcl copy 2023-04-14 22:04:50 +01:00
cancel all: Assert => Assertf 2023-03-03 14:37:43 -08:00
gsync Use a generic wrapper around `sync.Map` (#15878) 2024-04-09 10:56:25 +00:00
rpcdebug Remove deprecated Protobufs imports (#15158) 2024-01-17 09:35:20 +00:00
testutil all: Drop ioutil 2023-01-06 16:35:14 -08:00
tracing Update error handling (#8406) 2021-11-12 18:37:17 -08:00
validation Clean up uses of .Error() (#14965) 2023-12-20 15:54:06 +00:00
plugin.go [cli/plugin] Fix plugin install command when plugin type is tool (#16407) 2024-06-17 13:25:57 +00:00
plugin_test.go Refactor: move plugin kind to apitype (#15946) 2024-04-25 17:30:30 +00:00