mirror of https://github.com/pulumi/pulumi.git
6e986f90af
<!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> This is two changes rolled together in a way. Firstly passing some of the data that we pass on language runtime startup to also pass it to Run/GetRequiredPlugins/etc. This is needed for matrix testing, as we only get to start the language runtime up once for that but want to execute multiple programs with it. I feel it's also a little more consistent as we use the language runtimes in other contexts (codegen) where there isn't really a root directory, and aren't any options (and if we did do options the options for codegen are not going to be the same as for execution). It also means we can reuse a language host for shimless and substack programs, as before they heavily relied on their current working directory to calculate paths, and obviosly could only take one set of options at startup. Imagine a shimless python package + a python root program, that would have needed two startups of the python language host to deal with, this unblocks it so we can make the engine smarter and only use one. Secondly renaming some of the fields we pass to Run/GetRequiredPlugins/etc today. `Pwd` and `Program` were not very descriptive and had pretty non-obvious documentation: ``` string pwd = 3; // the program's working directory. string program = 4; // the path to the program to execute. ``` `pwd` will remain, although probably rename it to `working_directory` at some point, because while today we always start programs up with the working directory equal to the program directory that definitely is going to change in the future (at least for MLCs and substack programs). But the name `pwd` doesn't make it clear that this was intended to be the working directory _and_ the directory which contains the program. `program` was in fact nearly always ".", and if it wasn't that it was just a filename. The engine never sent a path for `program` (although we did have some unit tests to check how that worked for the nodejs and python hosts). These are now replaced by a new structure with (I think) more clearly named and documented fields (see ProgramInfo in langauge.proto). The engine still sends the old data for now, we need to update dotnet/yaml/java before we break the old interface and give Virtus Labs a chance to update [besom](https://github.com/VirtusLab/besom). ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @Pulumi employees: If yes, you must submit corresponding changes in the service repo. --> |
||
|---|---|---|
| .. | ||
| convert_testdata | ||
| pcl_convert_testdata | ||
| testdata | ||
| about.go | ||
| about_env.go | ||
| about_test.go | ||
| ai.go | ||
| ai_web.go | ||
| cancel.go | ||
| config.go | ||
| config_env.go | ||
| config_env_add.go | ||
| config_env_add_test.go | ||
| config_env_init.go | ||
| config_env_init_test.go | ||
| config_env_rm.go | ||
| config_env_rm_test.go | ||
| config_env_test.go | ||
| config_test.go | ||
| console.go | ||
| convert-trace.go | ||
| convert.go | ||
| convert_test.go | ||
| crypto.go | ||
| destroy.go | ||
| doc.go | ||
| env.go | ||
| errors.go | ||
| gen_completion.go | ||
| gen_markdown.go | ||
| import.go | ||
| import_test.go | ||
| install.go | ||
| login.go | ||
| logout.go | ||
| logs.go | ||
| logs_test.go | ||
| main.go | ||
| new.go | ||
| new_acceptance_test.go | ||
| new_test.go | ||
| org.go | ||
| org_search.go | ||
| org_search_ai.go | ||
| org_search_ai_test.go | ||
| org_search_test.go | ||
| package.go | ||
| package_extract_mapping.go | ||
| package_extract_schema.go | ||
| package_gen_sdk.go | ||
| package_pack_sdk.go | ||
| package_publish.go | ||
| plugin.go | ||
| plugin_install.go | ||
| plugin_install_test.go | ||
| plugin_ls.go | ||
| plugin_rm.go | ||
| policy.go | ||
| policy_disable.go | ||
| policy_enable.go | ||
| policy_group_ls.go | ||
| policy_ls.go | ||
| policy_new.go | ||
| policy_new_acceptance_test.go | ||
| policy_new_test.go | ||
| policy_publish.go | ||
| policy_publish_test.go | ||
| policy_rm.go | ||
| policy_validate.go | ||
| preview.go | ||
| preview_test.go | ||
| pulumi.go | ||
| pulumi_test.go | ||
| query.go | ||
| refresh.go | ||
| replay_events.go | ||
| schema.go | ||
| schema_check.go | ||
| stack.go | ||
| stack_change_secrets_provider.go | ||
| stack_change_secrets_provider_test.go | ||
| stack_export.go | ||
| stack_graph.go | ||
| stack_history.go | ||
| stack_import.go | ||
| stack_init.go | ||
| stack_init_test.go | ||
| stack_ls.go | ||
| stack_ls_test.go | ||
| stack_output.go | ||
| stack_output_fuzz_test.go | ||
| stack_output_test.go | ||
| stack_rename.go | ||
| stack_rm.go | ||
| stack_select.go | ||
| stack_tag.go | ||
| stack_test.go | ||
| stack_unselect.go | ||
| state.go | ||
| state_delete.go | ||
| state_edit.go | ||
| state_edit_encoder.go | ||
| state_edit_test.go | ||
| state_rename.go | ||
| state_rename_test.go | ||
| state_unprotect.go | ||
| state_upgrade.go | ||
| state_upgrade_test.go | ||
| terminal.go | ||
| terminal_test.go | ||
| up.go | ||
| up_test.go | ||
| util.go | ||
| util_remote.go | ||
| util_remote_test.go | ||
| util_test.go | ||
| version.go | ||
| view-trace.go | ||
| watch.go | ||
| whoami.go | ||
| whoami_test.go | ||