mirror of https://github.com/pulumi/pulumi.git
8e83ce445d
13480: Fix resoloution of aliased parent aliases. r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes https://github.com/pulumi/pulumi/issues/13324. When collapsing an alias that specifies a parent we need to use the parents alias if it had one. This is so that for example given a state with three resources: ``` urn:pulumi:test::test::prog:index:myStandardType::resA urn:pulumi:test::test::prog:index:myType::resB urn:pulumi:test::test::prog:index:myType$pkgAⓂ️typA::resC ``` Which is then updated such that resB and resC are re-parented to resA we end up with the following alias specifications: ``` resB: { NoParent = True} resC: { Parent = "urn:pulumi:test::test::prog:index:myStandardType$prog:index:myType::resB ``` Note that resC's alias uses the _new_ URN for resB. If we do a simple collapse of that alias we'd end up trying to find an old URN of `urn:pulumi:test::test::prog:index:myStandardType$prog:index:myType$pkgAⓂ️typA::resC` but actually it's old URN would have been `urn:pulumi:test::test::prog:index:myType$pkgAⓂ️typA::resC`. This change fixes alias to URN collapse to take into account if the parent was aliased so we get the correct old URN. ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Fraser Waters <fraser@pulumi.com> |
||
|---|---|---|
| .. | ||
| lifecycletest | ||
| deployment.go | ||
| destroy.go | ||
| detailedDiff.go | ||
| detailedDiff_test.go | ||
| doc.go | ||
| engine.go | ||
| errors.go | ||
| events.go | ||
| events_test.go | ||
| eventsink.go | ||
| import.go | ||
| journal.go | ||
| plugin_host.go | ||
| plugins.go | ||
| plugins_test.go | ||
| project.go | ||
| query.go | ||
| refresh.go | ||
| snapshot.go | ||
| update.go | ||
| update_test.go | ||