pulumi/pkg/resource/deploy
Will Jones 62293f05f7
Improve snapshot integrity panics depending on operation (#17144)
Snapshot integrity errors generally happen for one of two reasons:

* We just *wrote* a snapshot with an issue.
* We just attempted to *read* a snapshot with an issue.

As much as possible, we want to capture errors and issues at the point
of *writing* the snapshot, since that will generally be where the bug
that caused the integrity issue lies. This commit updates snapshot
integrity errors to carry awareness of whether they happened during a
read or write, and modifies the panic message to nudge users to hunt
down the failing write operation if the panic they are seeing relates to
a read.


![image](https://github.com/user-attachments/assets/6d91b5ea-95f5-470b-992f-1abfa116c838)

---------

Co-authored-by: Justin Van Patten <jvp@justinvp.com>
Co-authored-by: Eric Rudder <ericrudder@users.noreply.github.com>
2024-09-04 21:22:18 +00:00
..
deploytest debugging: more consistency for naming (#17152) 2024-09-04 10:36:45 +00:00
providers implement the engine bits for debugging support (#17072) 2024-08-30 10:31:28 +00:00
builtins.go Normalize plugin.Provider methods to (Context, Request) -> (Response, error) (#16302) 2024-06-07 19:47:49 +00:00
builtins_test.go Normalize plugin.Provider methods to (Context, Request) -> (Response, error) (#16302) 2024-06-07 19:47:49 +00:00
deployment.go implement the engine bits for debugging support (#17072) 2024-08-30 10:31:28 +00:00
deployment_executor.go continue-on-error: fix integrity issues in up with changed dependencies (#16733) 2024-07-22 11:25:33 +00:00
deployment_executor_test.go Better handle property dependencies and `deletedWith` (#16088) 2024-05-03 17:08:06 +00:00
deployment_test.go Clean up deployment options (#16357) 2024-06-11 13:37:57 +00:00
doc.go Document Go packages (#6009) 2021-01-11 11:07:59 -07:00
import.go Extend the TestReplacementParameterizedProvider test (#16644) 2024-07-15 08:33:36 +00:00
import_test.go Clean up deployment options (#16357) 2024-06-11 13:37:57 +00:00
manifest.go Split Manifest type to it's own file (#8712) 2022-01-10 12:25:24 +00:00
manifest_test.go Refactor: move plugin kind to apitype (#15946) 2024-04-25 17:30:30 +00:00
plan.go Enable perfsprint linter (#14813) 2023-12-12 12:19:42 +00:00
plan_test.go [ci] `pkg/resource/deploy` coverage (#14831) 2023-12-19 16:14:40 +00:00
snapshot.go Improve snapshot integrity panics depending on operation (#17144) 2024-09-04 21:22:18 +00:00
snapshot_test.go Revert "Revert "Run integration tests and dev builds with race detection" (#15998)" (#16148) 2024-05-09 16:15:41 +00:00
source.go Clean up deployment options (#16357) 2024-06-11 13:37:57 +00:00
source_error.go Clean up deployment options (#16357) 2024-06-11 13:37:57 +00:00
source_error_test.go Clean up deployment options (#16357) 2024-06-11 13:37:57 +00:00
source_eval.go debugging: more consistency for naming (#17152) 2024-09-04 10:36:45 +00:00
source_eval_test.go Update lifecycle test APIs to match provider APIs (#16793) 2024-07-26 12:14:45 +00:00
source_null.go Clean up deployment options (#16357) 2024-06-11 13:37:57 +00:00
source_query.go Initial work for parameterized providers (#16281) 2024-06-10 17:28:47 +00:00
source_query_test.go implement the engine bits for debugging support (#17072) 2024-08-30 10:31:28 +00:00
state_builder.go Revert "Revert "Run integration tests and dev builds with race detection" (#15998)" (#16148) 2024-05-09 16:15:41 +00:00
state_builder_test.go When changing parents also fix URNs (#13935) 2023-09-14 19:52:27 +00:00
step.go Don't set `PendingReplacement` until `Delete` succeeds (#16699) 2024-07-18 12:27:06 +00:00
step_executor.go Use int32 in Go interfaces that map to protobufs using int32 (#17068) 2024-08-28 13:45:17 +00:00
step_executor_test.go Clean up deployment options (#16357) 2024-06-11 13:37:57 +00:00
step_generator.go Fix snapshot integrity on pending replacement (#17146) 2024-09-04 10:52:43 +00:00
step_generator_test.go Clean up deployment options (#16357) 2024-06-11 13:37:57 +00:00
step_test.go Update lifecycle test APIs to match provider APIs (#16793) 2024-07-26 12:14:45 +00:00
target.go Add tokens.StackName (#14487) 2023-11-15 07:44:54 +00:00
target_test.go upgrade to latest version of golangci-lint (#15977) 2024-04-19 06:20:33 +00:00