mirror of https://github.com/pulumi/pulumi.git
f8236e125e
Currently, when generating docs for the AWSX package, Go constructor syntax examples were not generated due to a panic. This causes all constructor examples to not be emitted in the docs. The panic occurred when trying to get the version of referenced packages in the PCL program to emit import paths. However, _transitive_ package references were not resolved in the PCL binder when binding resource types. This PR fixes the problem such that now we do find the transitive package references from any input or output property of the resources being bound. In the case of the awsx package, the top-level package is awsx itself and aws is the transitive dependency. Anytime in codegen we call `program.PackageReferences()` we should get both of them. Added a unit test for this as well. Testing this fix locally against the awsx package showed constructor examples being generated for every language, however there was still a problem in the _formatting_ of Go code which is also fixed (see change in `gen_program_expressions.go`) Resolves part of #16463 |
||
|---|---|---|
| .. | ||
| 20240520--engine--guess-references-to-deeply-nested-properties-between-dependant-resources-during-import.yaml | ||
| 20240701--engine--dont-compute-refresh-diff-s-for-external-resources.yaml | ||
| 20240702--programgen-python--fix-python-program-generation-for-remote-assets.yaml | ||
| 20240702--sdk-nodejs--fix-creating-a-closure-with-object-getters-and-setters.yaml | ||
| 20240702--sdk-nodejs--update-atopentelemetry-dependencies.yaml | ||
| 20240703--backend-service--retry-post-requests-that-time-out-during-handshake-timeouts.yaml | ||
| 20240703--docs--fix-generating-constructor-syntax-examples-for-kubernetes.yaml | ||
| 20240703--engine--fix-program-hanging-when-the-import-resource-option-is-used-and-the-inputs-dont-match.yaml | ||
| 20240703--sdk-go--fix-slice-bounds-out-of-range-panic-in-fixuppath.yaml | ||
| 20240703--sdk-nodejs--add-dependson-to-invokeoptions-in-the-nodejs-sdk.yaml | ||
| 20240704--docs--fix-generating-constructor-syntax-examples-in-go-for-package-awsx.yaml | ||
| 20240705--programgen-go--do-not-emit-index-module-for-resources-without-a-schema.yaml | ||
| 20240708--cli-new--use-default-values-for-language-specific-prompts-when-using-yes.yaml | ||