pulumi/pkg/engine/lifecycletest
Thomas Gummerer 804c9bc7f3
fix hang when continue-on-error is used with import resource option (#16572)
This is a very similar fix to
https://github.com/pulumi/pulumi/pull/16371, but for imports instead of
create and updates.

When using the import resource option with continue-on-error, and there
is a diff in the import, the import fais, but we still also return the
completion function from the `Apply` call. This results in the engine
trying to call `Done` twice, which in turn results in it running
indefinitely, trying to write the result to a channel that's no longer
being read from.

Fix this by not returning the completion function from `Apply` for the
ImportStep when there is an error.

(I went through the other steps as well to double check we don't need a
similar fix there, and it looks like they are all fine).

Fixes: https://github.com/pulumi/pulumi/issues/16570
2024-07-03 10:24:26 +00:00
..
testdata fix hang when continue-on-error is used with import resource option (#16572) 2024-07-03 10:24:26 +00:00
alias_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
analyzer_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
continue_on_error_test.go fix hang when continue-on-error is used with import resource option (#16572) 2024-07-03 10:24:26 +00:00
delete_before_replace_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
golang_sdk_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
import_test.go Normalize plugin.Provider methods to (Context, Request) -> (Response, error) (#16302) 2024-06-07 19:47:49 +00:00
parameterized_test.go Keep package refs separate from providers (#16458) 2024-06-24 14:59:18 +00:00
pending_delete_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
pending_replace_test.go Don't re-delete resources that are `PendingReplacement` (#16510) 2024-06-28 23:16:20 +00:00
provider_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
pulumi_test.go Display `[retain]` in all cases of delete retention (#16506) 2024-06-28 23:19:26 +00:00
refresh_legacy_diff_test.go Change `pulumi refresh` to report diff relative to desired state instead of relative to only output changes (#16146) 2024-06-12 16:17:05 +00:00
refresh_test.go Don't call `Diff` when refreshing external resources (#16544) 2024-07-02 10:11:10 +00:00
resource_reference_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
retain_on_delete_test.go Display `[retain]` in all cases of delete retention (#16506) 2024-06-28 23:19:26 +00:00
source_query_test.go deploytest/RegisterResource: return struct instead of values (#15988) 2024-04-19 11:08:56 +00:00
step_generator_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00
target_test.go Propagate deleted dependencies of untargeted resources (#16247) 2024-05-23 12:31:03 +00:00
test_plan.go Normalize plugin.Provider methods to (Context, Request) -> (Response, error) (#16302) 2024-06-07 19:47:49 +00:00
transformation_test.go resolve providers in the engine before running transforms (#16409) 2024-06-21 08:55:17 +00:00
update_plan_test.go Add display to the engine tests (#16050) 2024-05-13 07:18:25 +00:00