mirror of https://github.com/pulumi/pulumi.git
6f1438146e
# Description We have some tests that ensure that types for pulumi/pulumi are compatible with the latest shipped version. However test failures do not result in CI failures. https://github.com/pulumi/pulumi/actions/runs/8153744675/job/22285983384#step:38:353 The current tests include a test using typescript 3.7.3 which does not pass. I upgraded this to match 3.8.3, which is what we use for pulumi/pulumi. I believe the yarn.lock in the tests was committed by accident. Fixes https://github.com/pulumi/pulumi/issues/15574 ## Checklist - [ ] I have run `make tidy` to update any new dependencies - [ ] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @Pulumi employees: If yes, you must submit corresponding changes in the service repo. --> |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| README.md | ||
| index.ts | ||
| package^3.json | ||
| package^4.json | ||
| package~3.8.3.json | ||
| tsconfig.json | ||
README.md
This test validates that changes we're making in @pulumi/pulumi will be side-by-side compatible with the 'latest' version of @pulumi/pulumi that has already shipped.
If a change is made that is not compatible, then the process should be:
- Ensure that the change is absolutely what we want to make.
- Disable running this test.
- Commit the change and update the minor version of
@pulumi/pulumi(i.e. from 0.17.x to 0.18.0). - Flow this change downstream, rev'ing the minor version of all downstream packages.
- Re-enable the test. Because there is now a new 'latest'
@pulumi/pulumi, this test should pass.
Step '3' indicates that we've made a breaking change, and that if 0.18 is pulled in from any package, that it must be pulled in from all packages.
Step '4' is necessary so that people can pick a set of packages that all agree on using this new @pulumi/pulumi version. While not necessary to rev the minor version of these packages, we still do so to make it clear that there is a significant change here, and that one should not move to it as readily as they would a patch update.