mirrors
/
pulumi
mirror of https://github.com/pulumi/pulumi.git
0
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
pulumi/tests/testdata/codegen
History
Zaid Ajaj 3bdc65c6e5
[program-gen] Fix enum resolution from types of the form Union[string, Enum] and emit fully qualified enum cases (#15696) 
# Description

This PR improves enum type resolution from strings. When we try to
resolve `Union[string, Enum]` for a string expression, we choose
`string` because it is the more general type since not every string is
assignable to `Enum`. However, here we spacial case strings that are
actually part of that `Enum`.

The result is that `pcl.LowerConversion` will choose `Enum` from
`Union[string, Enum]` when the value of the input string is compatible
with the enum. This greatly improves program-gen for all of typescript,
python, csharp and go which now will emit the fully qualified enum cases
instead of emitting strings.

Closes https://github.com/pulumi/pulumi-dotnet/issues/41 which is
supposed to be a duplicate of
https://github.com/pulumi/pulumi-azure-native/issues/2616 but that is
not the case (the former is about unions of objects, the latter is
unions of enums and strings)

## Checklist

- [ ] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
 		2024-03-15 17:49:12 +00:00
..
array-of-enum-map Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
assets-and-archives Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
assets-and-archives-go-generics-only Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
assets-archives-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-eks-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-fargate-output-versioned-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-fargate-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-iam-policy-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-lambda-pp [program-gen] Fix enum resolution from types of the form Union[string, Enum] and emit fully qualified enum cases (#15696) 2024-03-15 17:49:12 +00:00
aws-optionals-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-resource-options-4.26-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-resource-options-5.16.2-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-s3-folder-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-s3-logging-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-secret-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-static-website-pp [program-gen] Fix panic when generating programs for MLC packages using external types (#15605) 2024-03-10 17:23:15 +00:00
aws-webserver-pp [program-gen] Fix enum resolution from types of the form Union[string, Enum] and emit fully qualified enum cases (#15696) 2024-03-15 17:49:12 +00:00
azure-native-nested-types Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
azure-native-pp [program-gen] Fix enum resolution from types of the form Union[string, Enum] and emit fully qualified enum cases (#15696) 2024-03-15 17:49:12 +00:00
azure-sa-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
components-pp [program-gen/go] Fix optional primitive values being derefrenced (#15592) 2024-03-10 04:49:06 +00:00
config-variables-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
csharp-plain-lists-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
csharp-typed-for-expressions-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
cyclic-types Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
dash-named-schema Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
dashed-import-schema Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
different-enum Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
different-package-name-conflict Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
discriminated-union-pp [program-gen] Fix enum resolution from types of the form Union[string, Enum] and emit fully qualified enum cases (#15696) 2024-03-15 17:49:12 +00:00
docs-collision Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
dynamic-entries-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
embedded-crd-types Update descriptions for property types defined in an external package (#15651) 2024-03-14 22:10:14 +00:00
empty-list-property-pp [program-gen] Fix enum resolution from types of the form Union[string, Enum] and emit fully qualified enum cases (#15696) 2024-03-15 17:49:12 +00:00
entries-function-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
enum-reference Update descriptions for property types defined in an external package (#15651) 2024-03-14 22:10:14 +00:00
enum-reference-python Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
external-enum Update descriptions for property types defined in an external package (#15651) 2024-03-14 22:10:14 +00:00
external-go-import-aliases Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
external-node-compatibility Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
external-python-same-module-name Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
external-resource-schema Update descriptions for property types defined in an external package (#15651) 2024-03-14 22:10:14 +00:00
functions-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
functions-secrets Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
go-nested-collections Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
go-overridden-internal-module-name Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
go-plain-ref-repro Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
hyphen-url Update descriptions for property types defined in an external package (#15651) 2024-03-14 22:10:14 +00:00
hyphenated-symbols Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
inline-invokes-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
internal-dependencies-go Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
interpolated-string-keys-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
invalid-go-sprintf-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
invoke-inside-conditional-range-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
iterating-optional-range-expressions-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
kubernetes-operator-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
kubernetes-pod-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
kubernetes-template-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
kubernetes-template-quoted-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
kubernetes20 Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
legacy-names Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
logical-name-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
methods-return-plain-resource Update descriptions for property types defined in an external package (#15651) 2024-03-14 22:10:14 +00:00
modpath-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
multiline-string-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
naming-collisions Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
nested-module Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
nested-module-thirdparty Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
optional-complex-config-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
other-owned Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
output-funcs Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
output-funcs-aws-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
output-funcs-edgeorder Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
output-funcs-go-generics-only Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
output-funcs-tfbridge20 Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
output-literals-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
output-name-conflict-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
plain-and-default Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
plain-and-default-go-generics-only Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
plain-object-defaults Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
plain-object-disable-defaults Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
plain-schema-gh6957 Update descriptions for property types defined in an external package (#15651) 2024-03-14 22:10:14 +00:00
provider-config-schema Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
provider-type-schema Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
pulumi-stack-reference-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
python-regress-10914-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
python-regress-14037-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
python-reserved-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
python-resource-names-pp [program-gen] Fix enum resolution from types of the form Union[string, Enum] and emit fully qualified enum cases (#15696) 2024-03-15 17:49:12 +00:00
random-pet-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
read-file-func-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
regress-8403 Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
regress-11176-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
regress-go-8664 Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
regress-go-10527 Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
regress-go-12971 Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
regress-go-15478 Ensure package generation for Go SDKs doesn't panic when encountering overly nested arrays or maps of primitive types (#15680) 2024-03-14 14:21:15 +00:00
regress-node-8110 Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
regress-node-12507-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
regress-py-12546 Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
regress-py-12980 Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
regress-py-14012 Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
regress-py-14539 Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
regress-py-tfbridge-611 Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
replace-on-change [sdkgen/python] Replace-on-changes values should be camelCased (#15666) 2024-03-13 15:43:56 +00:00
resource-args-python Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
resource-args-python-case-insensitive Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
resource-property-overlap Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
retain-on-delete-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
schema Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
secrets Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
secrets-go-generics-only Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-enum-schema Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-enum-schema-go-generics-only Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-methods-schema Update descriptions for property types defined in an external package (#15651) 2024-03-14 22:10:14 +00:00
simple-methods-schema-single-value-returns Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-plain-schema Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-plain-schema-go-generics-only Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-plain-schema-with-root-package Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-range-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-resource-schema Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-resource-schema-custom-pypackage-name Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-resource-with-aliases Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-schema-pyproject Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-splat-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simple-yaml-schema Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simplified-invokes Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
simplified-invokes-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
single-or-none-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
snowflake-python-12998-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
string-enum-union-list-pp [program-gen] Fix enum resolution from types of the form Union[string, Enum] and emit fully qualified enum cases (#15696) 2024-03-15 17:49:12 +00:00
synthetic-resource-properties-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
third-party-package-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
throw-not-implemented-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
transpiled_examples [program-gen] Fix enum resolution from types of the form Union[string, Enum] and emit fully qualified enum cases (#15696) 2024-03-15 17:49:12 +00:00
traverse-union-repro-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
typed-enum-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
unions-inline Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
unions-inside-arrays Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
unknown-invoke-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
unknown-resource-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
urn-id-properties Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
using-dashes-pp Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
.gitignore Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
auto-deploy-0.0.1.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-4.15.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-4.26.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-4.36.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-4.37.1.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-5.4.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-5.16.2.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-native-0.13.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
aws-static-website-0.4.0.json [program-gen] Fix panic when generating programs for MLC packages using external types (#15605) 2024-03-10 17:23:15 +00:00
awsx-1.0.0-beta.5.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
azure-4.18.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
azure-native-1.28.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
azure-native-1.29.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
azure-native-1.56.0.json [program-gen] Fix enum resolution from types of the form Union[string, Enum] and emit fully qualified enum cases (#15696) 2024-03-15 17:49:12 +00:00
docker-3.1.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
docker-4.0.0-alpha.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
eks-0.37.1.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
eks-0.40.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
enum-1.0.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
google-native-0.18.2.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
google-native-0.27.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
kubernetes-3.0.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
kubernetes-3.7.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
kubernetes-3.7.2.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
lambda-0.1.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
localref-1.0.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
other-0.1.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
plain-properties-1.0.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
random-4.2.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
random-4.3.1.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
random-4.11.2.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
range-1.0.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
recursive-1.0.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
remoteref-1.0.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
snowflake-0.66.1.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
splat-1.0.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
std-1.0.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
synthetic-1.0.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
tls-4.10.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
types.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
using-dashes-1.0.0.json Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00