pulumi/sdk/nodejs/runtime/closure
Zaid Ajaj 4892fa1fd4
[sdk/nodejs] closure serializtion, lookup package.json from current directory up to parent directories (#13770)
# Description

When using closure serialization, we lookup `package.json` inside of the
current working directory `.`. However, if users put their
`package.json` file in a parent directory and their pulumi program in a
child directory, then it can't find `package.json` and fails to create
inline lambdas.

This PR addresses the issue by looking up `package.json` starting from
the current working directory recursively up parent directories until it
finds the closest `package.json` file and uses that as the "root" of the
project from which the dependencies are inferred.

Fixes #13764 

Didn't know how to write an integration test for this since the issue is
using pulumi/aws but locally testing these code changes succeed the
program.

## Checklist

- [ ] I have run `make tidy` to update any new dependencies
- [ ] I have run `make lint` to verify my code passes the lint check
  - [ ] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->

---------

Co-authored-by: Fraser Waters <fraser@pulumi.com>
2023-08-25 17:01:20 +00:00
..
codePaths.ts [sdk/nodejs] closure serializtion, lookup package.json from current directory up to parent directories (#13770) 2023-08-25 17:01:20 +00:00
createClosure.ts This commit safely replaces empty interfaces with type aliases. 2023-05-11 23:10:00 -04:00
package.ts Apply autoformat 2023-04-28 18:27:10 -04:00
parseFunction.ts Eliminate unnecessary double negations. 2023-05-09 18:35:59 -04:00
rewriteSuper.ts Apply autoformat 2023-04-28 18:27:10 -04:00
serializeClosure.ts Don't use the `delete` operator. 2023-04-28 22:07:35 -04:00
utils.ts Apply autoformat 2023-04-28 18:27:10 -04:00
v8.ts Apply autoformat 2023-04-28 18:27:10 -04:00
v8Hooks.ts Apply autoformat 2023-04-28 18:27:10 -04:00