pulumi/sdk/go/common
Fraser Waters 47ecd5a11d
Mark diff as an input diff when auto-diffing in the step generator (#14256)
<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. -->
Fixes https://github.com/pulumi/pulumi/issues/14040

When a provider returns `DiffUnknown` the step generator calculates a
simple diff based on the old and new inputs.

We were not correctly marking that this is an input diff, and so when
reconstructing objects from the detailed diff later in
`TranslateDetailedDiff` we we're looking at the old output properties
rather than the old input properties.

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->

---------

Co-authored-by: Justin Van Patten <jvp@justinvp.com>
2023-10-18 10:33:04 +00:00
..
apitype [cli] Add support for environments (#14140) 2023-10-10 01:35:39 +00:00
constant Send update metadata about update plans 2022-10-12 22:55:59 +01:00
diag [sdk] Update uniseg 2023-05-25 22:24:13 -07:00
encoding all: Reformat with gofumpt 2023-03-03 09:00:24 -08:00
env Add an envar to disable automatic provider installation (#14083) 2023-10-03 15:35:23 +00:00
resource Mark diff as an input diff when auto-diffing in the step generator (#14256) 2023-10-18 10:33:04 +00:00
slice Use slice.Prealloc instead of make([]T, 0, ...) 2023-06-29 11:27:50 +01:00
testing address comments: use os.UserHomeDir() and disable parallel tests 2023-06-26 13:53:58 +02:00
tokens Use fallback project name rather than "pulum" (#13953) 2023-09-18 18:01:37 +00:00
tools all: Reformat with gofumpt 2023-03-03 09:00:24 -08:00
util Use `assert.NoError` rather than `assert.Nil` (#14233) 2023-10-13 09:46:07 +00:00
version move pkg/version -> sdk/go/common/version 2020-03-18 15:25:25 -07:00
workspace Use `assert.NoError` rather than `assert.Nil` (#14233) 2023-10-13 09:46:07 +00:00