pulumi/pkg/codegen/testing/test
Will Jones 6f8cfbab9f
Don't publish test code in `pkg/codegen` (#17517)
Presently, we implement code generation (e.g. for SDKs and
programs/`pulumi convert`) on a per-language basis in `pkg/codegen`.
Alongside these implementations, we have a set of tests built using a
common framework that use snapshots to verify that code generation
doesn't break when changes are made. Unfortunately, due to the way
things are currently laid out in our repository, these tests and their
dependencies are shipped as part of the `pkg/codegen` package. This
commit brings @blampe's work in
https://github.com/pulumi/pulumi/pull/16011 up to date and fixes this by
taking the following actions:

* Test harnesses that were previously located in
`pkg/codegen/<language>/test.go` are moved to
`pkg/codegen/testing/test/<language>.go`.

By default, Go excludes files ending in `_test.go`, but *not* files
named e.g. `test.go`. It might seem logical therefore to just rename
these files (e.g. to `codegen_test.go`), so that they can continue to
live alongside their language implementations. Unfortunately, while this
fixes one problem (dependencies pulling in test code), it introduces
another -- the existing `test.go` files actually exist to implement an
interface which is used by the common codegen-test framework we have.
Moving to `*_test.go` files would make them invisible to the actual
modules which run the tests through that framework.

* Test code is consequently refactored to clean up the separation of
test details (e.g. relevant fixtures) and execution implementation
(working directory, means of program generation).

* The `gen_program_test/generate.go` program, which we use to generate
the "batch tests", has been updated so that it respects the new code
layout and organisation.

As laid out by @blampe in #16011 (and shamelessly copied here), this
brings a number of benefits. Test dependencies are no longer included in
non-test packages that are consumed downstream. As an example, this
takes the `pulumi-language-go` binary from ~61MB down to ~36MB, and
speeds up build times:

```
go clean -cache && time go build .
(master) go build .  81.06s user 17.36s system 470% cpu 20.933 total
(PR)     go build .  47.77s user 9.20s system 530% cpu 10.737 total
```

This doesn't completely remove these dependencies from downstream
because most also include `pkg/v3/testing/integration` in tests. It does
only compile these dependencies into the test binary, though.

Before:

```
❯ go mod why github.com/aws/aws-sdk-go-v2/service/sts
github.com/pulumi/pulumi-random/provider/v4/cmd/pulumi-tfgen-random
github.com/pulumi/pulumi-terraform-bridge/pf/tfgen
github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfgen
github.com/pulumi/pulumi/pkg/v3/codegen/dotnet
github.com/pulumi/pulumi/pkg/v3/testing/integration
github.com/pulumi/pulumi/pkg/v3/resource/stack
github.com/pulumi/pulumi/pkg/v3/secrets/cloud
github.com/pulumi/pulumi/pkg/v3/secrets/cloud.test
github.com/aws/aws-sdk-go-v2/service/sts
```

After:

```
github.com/pulumi/pulumi-random/provider/v4
github.com/pulumi/pulumi-random/provider/v4.test     <- expected
github.com/pulumi/providertest
github.com/pulumi/pulumi/pkg/v3/testing/integration
github.com/pulumi/pulumi/pkg/v3/resource/stack
github.com/pulumi/pulumi/pkg/v3/secrets/cloud
github.com/pulumi/pulumi/pkg/v3/secrets/cloud.test
github.com/aws/aws-sdk-go-v2/service/sts
```

Note: this PR has been split into a number of commits, roughly one per
language, to make reviewing a bit easier. The commits *do not build
individually* due to the nature of the changes, but hopefully it makes
understanding the work a bit more feasible.

Closes #16011

---------

Co-authored-by: Bryce Lampe <bryce@pulumi.com>
2024-10-09 11:09:54 +00:00
..
README.md Added README.md for SDKGen tests. 2023-03-01 08:39:36 -08:00
dotnet.go Don't publish test code in `pkg/codegen` (#17517) 2024-10-09 11:09:54 +00:00
generate.go Don't publish test code in `pkg/codegen` (#17517) 2024-10-09 11:09:54 +00:00
go.go Don't publish test code in `pkg/codegen` (#17517) 2024-10-09 11:09:54 +00:00
helpers.go Upgrade pulumi-dotnet to 3.67.1 (#17262) 2024-09-13 23:47:54 +00:00
nodejs.go Don't publish test code in `pkg/codegen` (#17517) 2024-10-09 11:09:54 +00:00
program_driver.go Don't publish test code in `pkg/codegen` (#17517) 2024-10-09 11:09:54 +00:00
program_driver_test.go Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00
python.go Don't publish test code in `pkg/codegen` (#17517) 2024-10-09 11:09:54 +00:00
sdk_driver.go Don't publish test code in `pkg/codegen` (#17517) 2024-10-09 11:09:54 +00:00
testdata Move codegen testdata (#15549) 2024-03-06 20:36:50 +00:00
type_driver.go Enable goheader rule and add missing license headers (#15473) 2024-09-09 12:05:45 +00:00

README.md

SDK Codegen Tests

TestSDKCodegen runs the complete set of SDK code generation tests against a particular language's code generator. It also verifies that the generated code is structurally sound.

The test files live in pkg/codegen/testing/test/testdata and are registered in the following globals in pkg/codegen/testing/test.

  • sdk_driver.go: PulumiPulumiSDKTests
  • program_driver.go: PulumiPulumiProgramTests
  • program_driver.go: PulumiPulumiYAMLProgramTests

An SDK code generation test files consists of a schema and a set of expected outputs for each language. Each test is structured as a directory that contains that information:

 testdata/
     my-simple-schema/   # i.e. `simple-enum-schema`
         schema.(json|yaml)
         go/
         python/
         nodejs/
         dotnet/
         ...

The schema is the only piece that must be manually authored.

Once the schema has been written, the actual codegen outputs can be generated by running the following in pkg/codegen directory:

PULUMI_ACCEPT=true go test ./...

This will rebuild subfolders such as go/ from scratch and store the set of code-generated file names in go/codegen-manifest.json. To generate the code for a specific directory in testdata, run the following instead:

PULUMI_ACCEPT=true go test ./... -run TestGenerate/$dirName

If these outputs look correct, they need to be checked into git and will then serve as the expected values for the normal test runs:

$ go test ./...

That is, the normal test runs will fail if changes to codegen or schema lead to a diff in the generated file set. If the diff is intentional, it can be accepted again via PULUMI_ACCEPT=true.

Writing Program Tests on Generated Code

To support running unit tests over the generated code, the tests also support mixing in manually written $lang-extras files into the generated tree. For example, given the following input:

 testdata/
     my-simple-schema/
         schema.json
         go/
         go-extras/
             tests/
                 go_test.go

The system will copy go-extras/tests/go_test.go into go/tests/go_test.go before performing compilation and unit test checks over the project generated in go.