pulumi/pkg/engine/lifecycletest/testdata/output/TestPendingReplaceResumeWit...
Fraser Waters 49d8298e84
Fix snapshot integrity on pending replacement (#17146)
This fixes a snapshot integrity issue with delete before replace, failed
creates, and multiple updates.

This was caused by https://github.com/pulumi/pulumi/pull/16510 where we
started removing pending replace resources as part of their replacement
steps. A well intentioned fix to stop trying to delete resources we'd
already deleted in a previous update.

The bug would manifest if the following happened:
1. An update goes to replace a resource with `deleteBeforeCreate` set.
It deletes the old resource (and saves the state as pending replace) but
then failed to create the new replacement resource.
2. A second update is run to try and create the replacement resource. At
this point the bug manifest and we delete the pending replace resource
from state, but then if the new resource fails to create again we end up
with an invalid snapshot.

The fix is very simple. If a resource is already pending replacement we
just don't issue a delete/remove step at all. The pending replace
resource will get cleaned up at the end by the create step creating the
new version.

Fixes #17111
Fixes #17073
Fixes #17070
Fixes #17069
Fixes #16916
2024-09-04 10:52:43 +00:00
..
0 Fix snapshot integrity on pending replacement (#17146) 2024-09-04 10:52:43 +00:00
1 Fix snapshot integrity on pending replacement (#17146) 2024-09-04 10:52:43 +00:00
2 Fix snapshot integrity on pending replacement (#17146) 2024-09-04 10:52:43 +00:00