mirror of https://github.com/pulumi/pulumi.git
d7ec486739
<!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> `property.Map` is just a plain map in many cases, users will send `dictionary` like values using property maps, and there's no guarantee their keys will stick to any sort of constraints. There are a number of places we a property map is used where we do know the keys should stick to some known constraints. Such as the property map for resource outputs, all the keys _should_ be valid property names (which aren't just any string). But firstly that knowledge is given by context, not by the type `property.Map` and secondly we're not really doing any validation of those places yet to check things do abide by any constraints so just using string everywhere for now is probably more honest. ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [x] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @Pulumi employees: If yes, you must submit corresponding changes in the service repo. --> --------- Co-authored-by: Thomas Gummerer <t.gummerer@gmail.com> |
||
|---|---|---|
| .. | ||
| equal_test.go | ||
| rapid.go | ||