mirror of https://github.com/pulumi/pulumi.git
0b13f9169d
This change fixes the `DeletedWith` resource option in the Go, Node.js, and Python SDKs and adds tests. This feature was a community contribution and while there were engine tests included with the original PR, there weren't any tests confirming the functionality worked correctly from each SDK. Here's a summary of the fixes: * Go: The `DeletedWith` resource option was never usable as it accepted a URN instead of a Resource. We discussed this internally a while back and decided to go ahead and fix this. (Note: While changing the signature is technically a breaking change, the feature is currently unusable, so the change would not break anyone, so there's no need to wait for a major version bump.) * Node.js: The `deletedWith` resource option did not work at all from the Node.js SDK because it was incorrectly passing the resource object itself in the RegisterResource request, rather than the resource's URN. * Python: The `deleted_with` resource option did not work at all from the Python SDK because it was incorrectly passing the resource object itself in the RegisterResource request, rather than the resource's URN. A `FailsOnDelete` resource has been added to the testprovider, which will fail when its `Delete` gRPC is called. The tests use this to ensure `Delete` is not called for resources of this type with the `DeletedWith` option specified. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| Pulumi.yaml | ||
| __main__.py | ||
| fails_on_delete.py | ||
| random_.py | ||
| requirements.txt | ||