mirror of https://github.com/pulumi/pulumi.git
3d1641b100
# Description This PR replaces the test program `discriminated-unions` with a new program `basic-unions` that uses a synthetic schema that has basic union definitions. The former program was failing compilation with Go because of a **faulty** azure-native SDK (tests using v1.56.0). It didn't generate the extra types for union objects (those with suffix `Args`). Those missing extra types are added in newer versions of azure-native SDK but the shape of the same resource doesn't have unions anymore so we can't just upgrade the version of the azure-native sdk we are testing with. I decided not to depend on a specific azure-native SDK and instead use a synthetic schema with the sole purpose of showing that we can emit correct code for fields assigned to object which are bound to different union cases. The downside here is that we can't compile the example for any language since it is a synthetic schema with no generated SDK (conformance tests in Go would make this possible but we are far away from that 😢) Closes #10834 since the original issue was due to faulty SDK, not program-gen. ## Checklist - [ ] I have run `make tidy` to update any new dependencies - [ ] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [ ] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @Pulumi employees: If yes, you must submit corresponding changes in the service repo. --> |
||
|---|---|---|
| .. | ||
| basic-unions.ts | ||