mirror of https://github.com/pulumi/pulumi.git
6dd2b02691
12643: Fix config set-all saving secret provider configuration r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Clean up some more hidden loading of config files in `getStackEncrypter`/`getStackDecrypter` that could cause the config file to change due to secret provider initialization. Importantly this was missed in `config set-all` where we would load the config file, then later on call `getStackEncrypter` which would initialize the secrets config and save it to disk, but not return that information back up to "set-all" which then overwrote it with the config structure that it had been building. This could result in secret values written to the config file but without saving their salt meaning they could never correctly be decrypted. Fixes https://github.com/pulumi/pulumi/issues/12632. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 12656: Fix panic in archive diff r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes https://github.com/pulumi/pulumi/issues/12655. ## Checklist <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> 12658: Log that we're falling back to get.pulumi.com r=Frassle a=Frassle <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Currently the "GitHub rate limit exceeded, try again in XmYs." errors look pretty bad because it's not clear that we then fallback got get.pulumi.com for our plugins when hitting this error. Adding this log line so it's a bit clearer what's going on when reading log files back. Co-authored-by: Fraser Waters <fraser@pulumi.com> |
||
|---|---|---|
| .. | ||
| about | ||
| aliases | ||
| cloud_secrets_provider | ||
| component_provider_schema | ||
| config_basic | ||
| config_capture_e2e/nodejs | ||
| config_secrets_warn | ||
| construct_component | ||
| construct_component_error_apply | ||
| construct_component_methods | ||
| construct_component_methods_errors | ||
| construct_component_methods_resources | ||
| construct_component_methods_unknown | ||
| construct_component_output_values | ||
| construct_component_plain | ||
| construct_component_provider | ||
| construct_component_slow | ||
| construct_component_unknown | ||
| construct_nested_component/go | ||
| custom_timeouts | ||
| delete_before_create | ||
| deleted_with | ||
| dependency_steps | ||
| double_pending_delete | ||
| duplicate_urns | ||
| dynamic | ||
| ee_perf | ||
| empty | ||
| enums | ||
| exclude_protected | ||
| explicit_provider | ||
| gather_plugin | ||
| get_created | ||
| get_resource | ||
| go | ||
| invalid_package_json | ||
| large_resource | ||
| nodejs | ||
| partial_state | ||
| partial_values | ||
| policy | ||
| printf | ||
| project_main | ||
| project_main_abs | ||
| project_main_parent/foo | ||
| protect_resources | ||
| provider_secret_config | ||
| python | ||
| python_await | ||
| query | ||
| read | ||
| recreate_resource_check | ||
| refresh/go | ||
| resource_refs_get_resource | ||
| rotate_passphrase | ||
| secret_outputs | ||
| single_resource | ||
| stack_bad_parenting | ||
| stack_dependencies | ||
| stack_outputs | ||
| stack_parenting | ||
| stack_project_name | ||
| stack_reference | ||
| stack_reference_multi/python | ||
| stack_reference_secrets/nodejs | ||
| steps | ||
| targets | ||
| transformations | ||
| tsconfig | ||
| types | ||
| unsafe_snapshot_tests/bad_resource | ||
| .gitignore | ||
| appdash_test.go | ||
| component_setup.sh | ||
| integration_acceptance_test.go | ||
| integration_go_acceptance_test.go | ||
| integration_go_test.go | ||
| integration_nodejs_acceptance_test.go | ||
| integration_nodejs_test.go | ||
| integration_python_acceptance_test.go | ||
| integration_python_test.go | ||
| integration_test.go | ||
| integration_util_test.go | ||