mirror of https://github.com/pulumi/pulumi.git
b8ace5096a
13011: Fix --replace behavior regression r=dixler a=dixler <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description `--replace` is not considered a targeted update. `--target-replace` works by adding the urn to the ReplaceTarget and also the UpdateTarget list. This commit removes a function that conflates the two and a test that incorrectly verifies this incorrect behavior. <!--- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. --> Fixes #13001 TODO: - [ ] squash commits ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [x] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Kyle Dixler <kyle@pulumi.com> |
||
|---|---|---|
| .. | ||
| 20230419--engine--provider-plugins-are-now-loaded-as-needed-not-at-startup-based-on-old-state-information.yaml | ||
| 20230518--sdkgen-go--for-properties-with-environment-variable-defaults-differentiate-between-unset-environment-variables-and-empty.yaml | ||
| 20230518--sdkgen-go--when-a-property-has-an-environment-variable-default-and-the-environment-variable-is-not-set.yaml | ||
| 20230519--cli-plugin--fixes-pulumi_debug_grpc-to-surface-provider-errors.yaml | ||
| 20230522--backend-filestate--fix-the-project-filter-when-listing-stacks-from-new-stores-that-support-per-project-stack-references.yaml | ||
| 20230523--sdkgen-go--fix-versioned-typerefs-being-marshalled-across-code-generator-rpcs.yaml | ||
| 20230524--cli-plugin--plugin-install-auto-fills-the-download-url-for-some-known-third-party-plugins.yaml | ||
| 20230524--engine--fix-replace-behavior-to-be-not-considered-a-targeted-update-where-only-replace-resources-would-be-targeted.yaml | ||
| 20230524--programgen--include-the-component-source-directory-in-diagnostics-when-reporting-pcl-errors.yaml | ||
| 20230525--cli--replace-heap-profiles-with-allocation-profiles.yaml | ||