pulumi/pkg/backend/display
Komal 78c7b7b072
Don't omit an empty detailedDiff (#15213)
<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. -->

When the detailedDiff object is empty, i.e. `{}`, it is dropped from the
serialized json due to the `omitempty`. When it is rehydrated on the
service, it is rehydrated as `nil` because it is not present in the json
object. That causes [this
line](516979770f/pkg/backend/display/rows.go (L442))
to be passed through and results in an input diff, which leads to the
output we see in the cloud of an import showing a lot of changed
properties when it should not (See issue for screenshots).

Fixes https://github.com/pulumi/pulumi-cloud-requests/issues/339

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2024-01-23 00:00:14 +00:00
..
internal/terminal turn on the golangci-lint exhaustive linter (#15028) 2024-01-17 16:50:41 +00:00
testdata Fix JSON/YAML diffs (#15171) 2024-01-18 14:19:54 +00:00
diff.go Enable perfsprint linter (#14813) 2023-12-12 12:19:42 +00:00
diff_test.go Fix JSON/YAML diffs (#15171) 2024-01-18 14:19:54 +00:00
display.go Check qualified type for root stackness (#14714) 2023-12-04 10:36:51 +00:00
doc.go Document Go packages (#6009) 2021-01-11 11:07:59 -07:00
events.go handle PolicyLoadEvent in more cases (#14600) 2023-11-17 09:15:31 +00:00
events_test.go Don't omit an empty detailedDiff (#15213) 2024-01-23 00:00:14 +00:00
json.go turn on the golangci-lint exhaustive linter (#15028) 2024-01-17 16:50:41 +00:00
jsonmessage.go Enable perfsprint linter (#14813) 2023-12-12 12:19:42 +00:00
object_diff.go Fix JSON/YAML diffs (#15171) 2024-01-18 14:19:54 +00:00
object_diff_test.go Fix a panic in diff display when parsing YAML strings (#14710) 2023-12-02 01:24:13 +00:00
options.go `pulumi new` with existing project now can be bypassed (#14081) 2023-10-20 15:43:29 +00:00
progress.go turn on the golangci-lint exhaustive linter (#15028) 2024-01-17 16:50:41 +00:00
progress_test.go Make `engine.NewEvent` type safe (#14590) 2023-11-16 16:54:03 +00:00
query.go turn on the golangci-lint exhaustive linter (#15028) 2024-01-17 16:50:41 +00:00
rows.go Allow anything in resource names (#14107) 2023-11-20 08:59:00 +00:00
sigint_unix.go [cli] Reimplement the interactive renderer 2022-11-07 22:02:44 -08:00
sigint_windows.go [cli] Reimplement the interactive renderer 2022-11-07 22:02:44 -08:00
tableutil.go [color] Use graphemes to measure strings. 2022-11-09 08:23:00 -08:00
tree.go Fixed panic in display on terminals with few rows and columns. 2023-03-30 16:16:48 -07:00
tree_test.go Fix data rate in backend/display/tree_test.go (#15006) 2023-12-27 20:16:51 +00:00
watch.go turn on the golangci-lint exhaustive linter (#15028) 2024-01-17 16:50:41 +00:00