pulumi/pkg/codegen/convert
Fraser Waters 26bf308dd0
Fix infinite loop bug in plugin_mapper (#15200)
<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. -->

Found by @GeoffMillerAZ a while back. Just tracked down exactly what
caused it. The test added hangs if ran on the current version of the
code.

Issue was we used to assume that we'd only stop looking for plugins once
there weren't any more plugins to look at. But then we added
`GetMappings` so we could see which providers a plugin mapped to
up-front. So the check needs to actually be stop looking when there's no
plugins _or_ when all the plugins left explicitly say they aren't for
the current lookup.

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [x] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [x] I have added tests that prove my fix is effective or that my
feature works
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [x] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2024-01-23 09:11:33 +00:00
..
mapper.go Make GetMapping contextful 2023-06-05 21:34:08 +01:00
mapper_client.go Make GetMapping contextful 2023-06-05 21:34:08 +01:00
mapper_server.go Make GetMapping contextful 2023-06-05 21:34:08 +01:00
plugin_mapper.go Fix infinite loop bug in plugin_mapper (#15200) 2024-01-23 09:11:33 +00:00
plugin_mapper_test.go Fix infinite loop bug in plugin_mapper (#15200) 2024-01-23 09:11:33 +00:00