mirror of https://github.com/pulumi/pulumi.git
43322f276a
When a serialized deployment doesn't include a secrets provider configuration, but does include ciphertexts, currently we end up with a panic. Error out earlier if this is the case to avoid the panic. This fixes the panic seen in https://github.com/pulumi/pulumi/issues/15547 and https://github.com/pulumi/pulumi/issues/14761, but it doesn't quite explain why this is happening in the first place. I asked for some more info from the users in these issues for that. Putting this up as PR anyway in case anyone has any idea of why this could be happening in the first place. I've tried spelunking through the code, but nothing obvious stood out. It is possible that these were still v2 snapshots that included no secrets manager, but I would be somewhat surprised if those still existed in the wild. Another potential solution here would be to try to pass the secret manager from the config in to the DeserializeDeployment function, so we could use that in these cases. It might not always be correct though, so I'm not sure it's the right thing to do. Thoughts? --------- Co-authored-by: Fraser Waters <fraser@pulumi.com> |
||
|---|---|---|
| .. | ||
| testdata | ||
| checkpoint.go | ||
| checkpoint_test.go | ||
| deployment.go | ||
| deployment_test.go | ||
| doc.go | ||
| plan.go | ||
| secrets.go | ||
| secrets_test.go | ||