pulumi/pkg/backend/display
Fraser Waters 54c956af6d
Send all events to the engine event stream (#14607)
<!--- 
Thanks so much for your contribution! If this is your first time
contributing, please ensure that you have read the
[CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md)
documentation.
-->

# Description

<!--- Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. -->

Currently the engine skips sending some resource events to the event
stream. Currently that's any "RemovePendingDelete" steps and anything to
do with default providers.

This was added so that we wouldn't display "internal implemntation
details" like default providers to the user in the tree or diff views.

However we wanted to use the engine event stream to support generating
an import file from preview deployments (make an import for every
resource that needs to be created). This mostly works except for the
imports we also need to know some of the provider details, and while the
event stream will tell us about explicit providers the skipping of
default providers means we can't get their information in the import
generater code.

So this moves this filtering out of the engine and to the display logic
instead. We still leave it up to the engine to mark what events it
considers "internal" but they're always sent to the event stream.

## Checklist

- [x] I have run `make tidy` to update any new dependencies
- [x] I have run `make lint` to verify my code passes the lint check
  - [ ] I have formatted my code using `gofumpt`

<!--- Please provide details if the checkbox below is to be left
unchecked. -->
- [ ] I have added tests that prove my fix is effective or that my
feature works - This shouldn't change anything user visible so should be
covered by existing tests
<!--- 
User-facing changes require a CHANGELOG entry.
-->
- [ ] I have run `make changelog` and committed the
`changelog/pending/<file>` documenting my change - No user visible
change
<!--
If the change(s) in this PR is a modification of an existing call to the
Pulumi Cloud,
then the service should honor older versions of the CLI where this
change would not exist.
You must then bump the API version in
/pkg/backend/httpstate/client/api.go, as well as add
it to the service.
-->
- [ ] Yes, there are changes in this PR that warrants bumping the Pulumi
Cloud API version
<!-- @Pulumi employees: If yes, you must submit corresponding changes in
the service repo. -->
2023-11-20 21:55:59 +00:00
..
internal/terminal [cli] Add an "open in browser" keybinding 2023-03-09 15:52:13 -08:00
testdata Policy remediations feature (#14080) 2023-10-09 18:31:17 +00:00
diff.go handle PolicyLoadEvent in more cases (#14600) 2023-11-17 09:15:31 +00:00
diff_test.go Make `engine.NewEvent` type safe (#14590) 2023-11-16 16:54:03 +00:00
display.go Send all events to the engine event stream (#14607) 2023-11-20 21:55:59 +00:00
doc.go Document Go packages (#6009) 2021-01-11 11:07:59 -07:00
events.go handle PolicyLoadEvent in more cases (#14600) 2023-11-17 09:15:31 +00:00
events_test.go Make `engine.NewEvent` type safe (#14590) 2023-11-16 16:54:03 +00:00
json.go handle PolicyLoadEvent in more cases (#14600) 2023-11-17 09:15:31 +00:00
jsonmessage.go all: Reformat with gofumpt 2023-03-03 09:00:24 -08:00
object_diff.go Move sdk/go/common/display to /pkg/display (#13954) 2023-09-18 11:01:28 +00:00
object_diff_test.go Fix diff display partially parsing JSON/YAML 2023-06-22 09:31:10 +01:00
options.go `pulumi new` with existing project now can be bypassed (#14081) 2023-10-20 15:43:29 +00:00
progress.go Make `engine.NewEvent` type safe (#14590) 2023-11-16 16:54:03 +00:00
progress_test.go Make `engine.NewEvent` type safe (#14590) 2023-11-16 16:54:03 +00:00
query.go handle PolicyLoadEvent in more cases (#14600) 2023-11-17 09:15:31 +00:00
rows.go Allow anything in resource names (#14107) 2023-11-20 08:59:00 +00:00
sigint_unix.go [cli] Reimplement the interactive renderer 2022-11-07 22:02:44 -08:00
sigint_windows.go [cli] Reimplement the interactive renderer 2022-11-07 22:02:44 -08:00
tableutil.go [color] Use graphemes to measure strings. 2022-11-09 08:23:00 -08:00
tree.go Fixed panic in display on terminals with few rows and columns. 2023-03-30 16:16:48 -07:00
tree_test.go Fixed panic in display on terminals with few rows and columns. 2023-03-30 16:16:48 -07:00
watch.go Allow anything in resource names (#14107) 2023-11-20 08:59:00 +00:00