mirror of https://github.com/pulumi/pulumi.git
e0918723ae
Semver allows you to attach "build metadata" to a version by appending the version with `+` and then metadata. In #2216 we started to take advantage of this as the place to put the git commit information, instead of including it as part of the "version". This is more in line with what Semver expects to be done, because git commit information isn't orderable. Because of this, we started to publish plugins with versions like `v0.16.5-dev.1542649729+g07d8224`. However, our logic for discovering plugins in the cache did an initial filtering based on folder names in the cache and the regex did not allow a + in the "version" field. This meant that from the point of view of the cache, the plugin was not present. This would lead to very confusing behavior where something like `pulumi plugin install resource azure v0.16.5-dev.1542649729+g07d8224` would download the plugin, but `pulumi plugin ls` would not see it and attempting to do an update with it would fail with an error saying the plugin was not installed. This change relaxes the regular expression to allow it to match these sorts of paths. We still use the `semver` library to ensure that the version we've extracted from the directory name is a valid semver. |
||
|---|---|---|
| .. | ||
| creds.go | ||
| paths.go | ||
| plugins.go | ||
| project.go | ||
| project_test.go | ||
| settings.go | ||
| templates.go | ||
| templates_test.go | ||
| workspace.go | ||