mirror of https://github.com/pulumi/pulumi.git
0d1d57f1f9
13136: Add explicit package versioning to Go codegen r=guineveresaenger a=guineveresaenger <!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description This PR adds logic to explicitly set a Go SDK version as well as pluginDownloadURL in the SDK itself. This will allow us to publish tags with explicit versions, ensure the engine references the correct plugin version, and will allow for the provider to use the correct version plugin much more reliably. This PR adds a new `pulumiVersion` file and refactors the `pulumiUtilities` file to live alongside the new version file in an `internal` folder for utilities. This allows all resources in the provider to call on `internal.PkgVersion` without generating a mod-level utilities file alongside. I have tested this against a flat structure SDK (pulumi-docker) and a modular SDK (pulumi-okta). I have also edited the `schema.json` files in the unit tests to reflect the new utilities path. The changes in the PR will allow us to: 1. Read a version into `pulumiVersion.go` during codegen 2. Commit and tag that commit as `sdk/v<Version>` 3. Have the exact same SDK that was built and tested be available on github 4. Clean up the CI step that explicitly tags the Go SDK. Fixes #13012 ## Checklist - [ ] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [x] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [x] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- `@Pulumi` employees: If yes, you must submit corresponding changes in the service repo. --> Co-authored-by: Guinevere Saenger <guinevere@pulumi.com> |
||
|---|---|---|
| .. | ||
| docs | ||
| dotnet | ||
| go | ||
| nodejs | ||
| python | ||
| schema.json | ||