mirror of https://github.com/pulumi/pulumi.git
49d8298e84
This fixes a snapshot integrity issue with delete before replace, failed creates, and multiple updates. This was caused by https://github.com/pulumi/pulumi/pull/16510 where we started removing pending replace resources as part of their replacement steps. A well intentioned fix to stop trying to delete resources we'd already deleted in a previous update. The bug would manifest if the following happened: 1. An update goes to replace a resource with `deleteBeforeCreate` set. It deletes the old resource (and saves the state as pending replace) but then failed to create the new replacement resource. 2. A second update is run to try and create the replacement resource. At this point the bug manifest and we delete the pending replace resource from state, but then if the new resource fails to create again we end up with an invalid snapshot. The fix is very simple. If a resource is already pending replacement we just don't issue a delete/remove step at all. The pending replace resource will get cleaned up at the end by the create step creating the new version. Fixes #17111 Fixes #17073 Fixes #17070 Fixes #17069 Fixes #16916 |
||
|---|---|---|
| .. | ||
| deploytest | ||
| providers | ||
| builtins.go | ||
| builtins_test.go | ||
| deployment.go | ||
| deployment_executor.go | ||
| deployment_executor_test.go | ||
| deployment_test.go | ||
| doc.go | ||
| import.go | ||
| import_test.go | ||
| manifest.go | ||
| manifest_test.go | ||
| plan.go | ||
| plan_test.go | ||
| snapshot.go | ||
| snapshot_test.go | ||
| source.go | ||
| source_error.go | ||
| source_error_test.go | ||
| source_eval.go | ||
| source_eval_test.go | ||
| source_null.go | ||
| source_query.go | ||
| source_query_test.go | ||
| state_builder.go | ||
| state_builder_test.go | ||
| step.go | ||
| step_executor.go | ||
| step_executor_test.go | ||
| step_generator.go | ||
| step_generator_test.go | ||
| step_test.go | ||
| target.go | ||
| target_test.go | ||